Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#4896 closed defect (bug) (fixed)

Installed Component Counts

Reported by: netweb Owned by:
Priority: normal Milestone: 1.7
Component: Core Version: 1.7
Severity: normal Keywords: has-patch commit
Cc:

Description

Two parts to this... See attached screenshot...


  • I'm told 3 are active, I count 4 active (2 must-use)
  • 'All' should be 10 but I get the idea behind this in hiding as much as possible of the retired bbPress 1.x 'Group Forums'. Not sure what the best option to do here is, probably leave it the way it is...

Attachments (2)

funky-components-counts.png (35.7 KB ) - added by netweb 13 years ago.
4896.01.patch (700 bytes ) - added by DJPaul 13 years ago.

Download all attachments as: .zip

Change History (7)

#1 @DJPaul
13 years ago

If you save the active components without making any changes, the count corrects itself.

@DJPaul
13 years ago

#2 @DJPaul
13 years ago

  • Keywords has-patch dev-feedback added
  • Milestone Awaiting Review1.7

Members component wasn't being activated by default on a new install. 4896.01.patch addresses this and thus fixes the count, but i'm not sure if there are other consequences of members being active (or not being active) here.

#3 @boonebgorges
13 years ago

  • Keywords commit added; dev-feedback removed

From BP's point of view, it doesn't really matter whether 'members' is included in the bp-active-components array - it's a required component, and is force-loaded in the main bootstrap method: https://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-loader.php#L44

So I think that this patch should be fine.

#4 @djpaul
13 years ago

  • Resolutionfixed
  • Status newclosed

(In [6873]) Fix inaccurate active component count on BP settings screen for new installs. Fixes #4896

The members component is a mandatory component, which we always activate. The active component count only counts active components.
On new installs, the members component was not being set active, leading to the discrepancy. Saving the settings screen (without making any changes) also "fixed" the count as the save routine re-calculates the active components array.

#5 @johnjamesjacoby
12 years ago

  • Version 1.7-beta1.7
Note: See TracTickets for help on using tickets.