Opened 10 years ago
Closed 10 years ago
#4892 closed defect (bug) (fixed)
bp_activity_latest_update_content filter is present but not utilised when saving activity content in usermeta
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 1.8 | Priority: | low |
Severity: | minor | Version: | 1.6 |
Component: | Activity | Keywords: | has-patch early commit |
Cc: |
Description
'bp_activity_latest_update_content' filters content. But after filtering, the original unfiltered content is added in the database. Just adding it appropriately will let developers filter it for other types of content.
Attachments (3)
Change History (12)
#2
@
10 years ago
- Keywords reporter-feedback added
Good spot. All the filters for content here look a bit funky; 4892.02.patch makes it better, but it does move bp_activity_latest_update_content before bp_activity_new_update_content
#4
@
10 years ago
- Keywords commit added
Patch here looks good to me. Feel free to 1.7 it if you'd like.
#5
@
10 years ago
I feel, the two should be kept separate. The latest update might need different handling than the actual activity that shows up in the activity stream.
So, the array that goes into bp_activity_add can remain as it is. That is handled separately and nicely. Let this be distinct.
#7
@
10 years ago
- Keywords early added
- Milestone changed from Awaiting Review to 1.8
- Priority changed from normal to low
- Severity changed from normal to minor
- Version changed from 1.7 to 1.6
Not a regression, so moving to 1.8. This function is weird in general, so let's address it early in 1.8.
Fixes latest update filtering