Skip to:

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#4890 closed defect (bug) (fixed)

BP Theme Compat and no-js body class

Reported by: imath's profile imath Owned by:
Milestone: 1.7 Priority: high
Severity: major Version: 1.7
Component: Templates Keywords: has-patch commit



If on BP Theme Compat, the no-js class is not added to the body tag. As a result, if the browser has disabled javascript, then, for instance, the activity post button is not visible. However, the bp-legacy/css/buddypress.css contains some style for the no-js class... So i suggest the diff attached to this ticket in order to add the no-js class to body class and let bp-legacy/js/buddypres.js replaces this class by a 'js' one.

Attachments (2)

4890.diff (2.0 KB) - added by imath 11 years ago.
4890-improved.diff (2.0 KB) - added by imath 11 years ago.

Download all attachments as: .zip

Change History (8)

11 years ago

#1 follow-up: @boonebgorges
11 years ago

  • Milestone changed from Awaiting Review to 1.7
  • Priority changed from normal to high
  • Severity changed from minor to major

This must be fixed if true. Moving to 1.7 for review.

11 years ago

#2 in reply to: ↑ 1 @imath
11 years ago

Replying to boonebgorges:

This must be fixed if true. Moving to 1.7 for review.

That's what i've noticed in twentytwelve. Then i thought, if a theme adds a no-js, maybe the filter should be done later and check the body_class array before adding the no-js class..

That's why i added the 4890-improved.diff

#3 @DJPaul
11 years ago


#4 @johnjamesjacoby
11 years ago

  • Keywords commit added; 2nd-opinion removed

Looks good to me.

#5 @djpaul
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6850]) Add no-js body class when in theme compat. Fixes #4890, props imath

The absence of this class is used by the JS and CSS to style UI elements appropriately if the user has chosen to disable JavaScript.
This change resolves a regression from the behaviour in BP-Default.

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.