BP Theme Compat and no-js body class

[imath]

Hi,

If on BP Theme Compat, the no-js class is not added to the body tag. As a result, if the browser has disabled javascript, then, for instance, the activity post button is not visible. However, the bp-legacy/css/buddypress.css contains some style for the no-js class... So i suggest the diff attached to this ticket in order to add the no-js class to body class and let bp-legacy/js/buddypres.js replaces this class by a 'js' one.

[boonebgorges]

This must be fixed if true. Moving to 1.7 for review.

[imath]

Replying to boonebgorges:

This must be fixed if true. Moving to 1.7 for review.

That's what i've noticed in twentytwelve. Then i thought, if a theme adds a no-js, maybe the filter should be done later and check the body_class array before adding the no-js class..

That's why i added the 4890-improved.diff

[DJPaul]

Confirmed

[johnjamesjacoby]

Looks good to me.

[djpaul]

(In [6850]) Add no-js body class when in theme compat. Fixes #4890, props imath

The absence of this class is used by the JS and CSS to style UI elements appropriately if the user has chosen to disable JavaScript.
This change resolves a regression from the behaviour in BP-Default.