Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#4880 closed enhancement (fixed)

1.7 Beta 2 content double displayed in a group

Reported by: jackvd's profile jackvd Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.7
Component: Groups Keywords: has-patch commit
Cc: jackvd

Description

The titel, avatar, group description and editor is displayed double on a group page.

Attachments (1)

4880.01.patch (1.4 KB) - added by r-a-y 12 years ago.

Download all attachments as: .zip

Change History (23)

#1 @boonebgorges
12 years ago

  • Keywords reporter-feedback added

Please share detailed information about your setup:

  • WP version
  • What theme are you using
  • Whether this is a new install or an upgrade
  • Exact steps to reproduce

#2 @jackvd
12 years ago

  • Component changed from Core to Groups

#3 @jackvd
12 years ago

Theme: responsive, Twenty elven and yoko
Wp: 3.5.5 NL
Its an upgrade
1) i try to deactivate buddypress 1.7 beta1, 2) website was not accessibel anymore, 3) via ftp i upgrade buddypress to beta2, 3) still no acces, 4) via ftp i changed plugin folder into plugin1 and delete buddypress plugin, 4) website was accessibele, 5) changed folder from plugin1 to plugin, 6) activated all plugins.

Lost of succes! Thx Jack

#4 @jackvd
12 years ago

  • Cc jackvd added
  • Severity changed from normal to critical

Same issue is also applicable for the activity page.

#5 @boonebgorges
12 years ago

  • Severity changed from critical to normal

Same issue is also applicable for the activity page.

Please be more specific. You listed a number of issues, some of which involved content (avatar, group description, editor) that does not appear on an activity page.

#6 @jackvd
12 years ago

I thought Issue 4 in ticket 4881 (also visualized in the attchment of 4881) is only applicable for group pages. Unfortunatly it is also applicable for the activity page. Issue 4 of ticket 4881 is equal to ticket 4880

#7 @jackvd
12 years ago

: When login the editor on the activity page and all posts are shown 2 times.

#8 @jackvd
12 years ago

Just find out thta above problem doesn't exists with a new installation. Looks like the problem is limited to upgraded wordpress/buddypress installations.

#9 @r-a-y
12 years ago

The problem with Yoko is the page loop is not set up correctly.

Yoko's page.php looks like this:

	<?php the_post(); ?>
	<?php get_template_part( 'content', 'page' ); ?>
	<?php comments_template( '', true ); ?>

It should look like this:

	<?php while ( have_posts() ) : the_post(); ?>
		<?php get_template_part( 'content', 'page' ); ?>
		<?php comments_template( '', true ); ?>
	<?php endwhile; // end of the loop. ?>

To confirm, this bug is only happening with Yoko, correct?

#10 @jackvd
12 years ago

Unfortinately it's not only happening with yoko, but als with responsive

#11 @jackvd
12 years ago

Issue is also with Twenty twelve.

#12 @boonebgorges
12 years ago

#4881 marked as duplicate.

#13 @boonebgorges
12 years ago

  • Keywords dev-feedback added; reporter-feedback removed

To clarify, the issue being pointed out by jackvd are:

  1. On single group pages, group titles are being displayed twice: once above all page content (where the page title goes), and once below the group avatar.
  2. The text of group descriptions is small and, presumably, difficult to read.
  3. On some pages, the entire page content is being displayed twice.
  4. There is a colored outline around the edges of the activity posting div.

I've done some testing in Twenty Twelve, Twenty Eleven, Yoko, and Responsive. My conclusions:

  • 1 does seem to be an issue. What does the rest of the team think about removing the group name from group-header.php?
  • 2 is an aesthetic issue. It was deemphasized on purpose, presumably because it appears so frequently but only needs to be read once. I'm going to suggest no change on this, unless it can be shown that we're not meeting with accessibility requirements.
  • I can't reproduce 3. I'm guessing that there is a plugin conflict that's messing with 'the_content'.
  • As for 4, the screenshot in the PDF attached to #4881 is from the plugin BuddyPress Activity Plus, so it's not a BP core issue. Please fix the issue with CSS, or contact that plugin's author.

To recap, only 1 appears to be a valid issue.

#14 @jackvd
12 years ago

3) After turning off all plugins and deleting the ones i don't use issue 3 disapears. Unfortunately i don't know which plugin cause the problem.

#15 @jackvd
12 years ago

After activating the plugins i want to use, issue 3 is not valid anymore. Happy with that! Woud be great if you would solve issue1. Cheers Jack

#16 @DJPaul
12 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

This is currently working as intended, and we're moving it to the future release milestone to give time to gather feedback after 1.7 ships and see if/how we want to address it in future.

Relevant IRC log: https://irclogs.wordpress.org/chanlog.php?channel=buddypress-dev&day=2013-03-20&sort=asc#m187937

@r-a-y
12 years ago

#17 @r-a-y
12 years ago

  • Keywords has-patch added

Attached patch addresses issue no. 1 as pointed out by Boone here.

#18 @johnjamesjacoby
12 years ago

  • Milestone changed from Future Release to 1.7

I don't feel strongly either way, and can see pros and cons to either approach. Having continuity between components and templates is probably best for bp-legacy, so I'm fine with the proposed patch.

#19 @boonebgorges
12 years ago

  • Keywords commit added

+1 to being consistent, and +1 to the patch.

#20 @johnjamesjacoby
12 years ago

Seems we're in agreement. Patch is good, commit is go.

#21 @r-a-y
12 years ago

(In [6876]) Remove duplicate group title on group pages. See #4880.

#22 @DJPaul
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.