#488 closed defect (bug) (fixed)
Unmarked strings in rc1
Reported by: | mburp | Owned by: | nbachiyski |
---|---|---|---|
Milestone: | Priority: | major | |
Severity: | Version: | 1.0 | |
Component: | Keywords: | localization | |
Cc: | mburp |
Description
This is what I have so far. If you leave this open, I'll add the rest as I finish reviewing the files.
BP 1.0 rc1 looks much, much better - thank you!
bp-core.php:
788: date <code>$date = date( "F j, Y ", $time );</code> to <code>$date = date( ("F j, Y ", 'buddypress'), $time );</code>
791: time <code>date( ' g:iA', $time );</code> to <code>date( (' g:iA', 'buddypress'), $time );</code>
bp-friends.php
169: value <code>value="'yes"</code> to <code>value="<?php _e( 'yes', 'buddypress' ) ?>"</code>
170: value <code>value="no"</code> to <code>value="="<?php _e( 'no', 'buddypress') ?>"</code>
174 and 176: repeat previous yes no values
bp-groups.php
874 and 875: repeat yes no values
880 and 881: repeat yes no values
887 and 888: repeat yes no values
894 and 895: repeat yes no values
900 and 901: repeat yes no values
1529: <code>$group_name . ' - Forum' , $group_name</code> to <code>$group_name . (' - Forum', 'buddypress') , $group_name</code>
bp-messages.php
257 and 258: repeat yes no values
263 and 264: repeat yes no values
287: <code>'name' => ('From: ' . BP_Messages_Thread::get_last_sender($thread_id), 'buddypress'),</code> not sure this will work
bp-xprofile.php
320 and 321: repeat yes no values
591 and 594: <code>title="Wire"</code> not sure about this
bp-activity-friends-feed.php
25: <code><?php _e( sprintf( '%s - Friends Activity Feed', $bp->displayed_user->fullname ), 'buddypress' ) ?></code> won't work
26: <code><pubDate><?php echo mysql2date('D, d M Y H:i:s +0000', bp_activity_get_last_updated(), false); ?></pubDate></code> not sure
38: similar to above
bp-activity-personal-feed.php
24: <code><?php _e( sprintf( '%s - Activity Feed', $bp->displayed_user->fullname ), 'buddypress' ) ?></code> won't work
25: <code><?php echo mysql2date('D, d M Y H:i:s +0000', bp_activity_get_last_updated(), false); ?></code> not sure
35: <code><?php echo mysql2date('D, d M Y H:i:s +0000', bp_activity_feed_item_date(), false); ?></code> not sure
bp-activity-sitewide-feed.php
26:<code><?php echo mysql2date('D, d M Y H:i:s +0000', bp_activity_get_last_updated(), false); ?></code> not sure
38:<code><?php echo mysql2date('D, d M Y H:i:s +0000', $activitypubdate?, false); ?></code> not sure
bp-blogs-ajax.php
48: <code><img src="<?php echo 'http://www.gravatar.com/avatar/' . md5( $blog->blog_id . '.blogs@' . $bp->root_domain ) . '?d=identicon&s=50'; ?>" class="avatar" alt="Blog Identicon" /></code> to <img src="<?php echo 'http://www.gravatar.com/avatar/' . md5( $blog->blog_id . '.blogs@' . $bp->root_domain ) . '?d=identicon&s=50'; ?>" class="avatar" alt="( 'Blog Identicon', 'buddypress' )" />
58: <code><a href="<?php echo get_blog_option( $blog->blog_id, 'siteurl' ) ?>" class="visit" title="Visit <?php echo get_blog_option( $blog->blog_id, 'blogname' ) ?>"><?php _e( 'Visit Blog', 'buddypress' ) ?></a></code> not sure
63: <code>_e( sprintf( 'Latest Post: %s', '<a href="' . bp_post_get_permalink( $post[0], $blog->blog_id ) . '">' . apply_filters( 'the_title', $post[0]->post_title ) . '</a>' ), 'buddypress' );</code> won't work
bp-blogs-templatetags.php
272: <code>function bp_post_comments( $zero = 'No Comments', $one = '1 Comment', $more = '% Comments', $css_class = , $none = 'Comments Off' )</code> probably okay
Bp-blogs-widgets.php
44: <code><div class="item-meta"><em>by <?php echo bp_core_get_userlink($post->post_author) ?> from the blog "<a href="<?php echo get_blog_option($post->blog_id, 'siteurl') ?>"><?php echo get_blog_option($post->blog_id, 'blogname') ?></a>"</em></div></code> It would be nice if the two sentence fragments weren’t separated.
Bp-blogs-directory-blogs.php
106: <code><div class="item-meta"><span class="activity"><?php echo bp_core_get_last_activity( bp_blogs_get_blogmeta( $blog->blog_id, 'last_activity' ), ('active %s ago') ) ?></span></div></code> needs domain
111: <code><a href="<?php echo get_blog_option( $blog->blog_id, 'siteurl' ) ?>" class="visit" title="Visit <?php echo get_blog_option( $blog->blog_id, 'blogname' ) ?>"><?php _e( 'Visit Blog', 'buddypress' ) ?></a></code> title should be marked as well – nice if it weren’t a fragment
116: <code>_e( sprintf( 'Latest Post: %s', '<a href="' . bp_post_get_permalink( $post[0], $blog->blog_id ) . '">' . apply_filters( 'the_title', $post[0]->post_title ) . '</a>' ), 'buddypress' );</code> won’t work
158: <code><input type="submit" id="blogs_search_submit" name="blogs_search_submit" value="Search" /></code>
177: <code><div class="item-meta"><span class="activity"><?php echo bp_core_get_last_activity( bp_blogs_get_blogmeta( $blog->blog_id, 'last_activity' ), ('active %s ago') ) ?></span></div></code> needs domain
Bp-core-activation.php
128: <code>$message = sprintf(( apply_filters( 'wpmu_signup_user_notification_email', "To activate your user, please click the following link:\n\n%s\n\nAfter you activate, you will receive *another email* with your login.\n\n" ) ), clean_url( bp_activation_page( false ) . "?key=$key") );</code> begin after apply_filters(, not before
129:<code>$subject = sprintf(( apply_filters( 'wpmu_signup_user_notification_subject', 'Activate %s' )), $user);</code> same
Bp-core-admin.php
55:<core><input type="radio" name="bp-admin[show-loggedout-adminbar]"<?php if ( (int)get_site_option( 'show-loggedout-adminbar' ) ) : ?> checked="checked"<?php endif; ?> id="bp-admin-show-loggedout-adminbar-yes" value="1" /> Yes </core>
56:<core><input type="radio" name="bp-admin[show-loggedout-adminbar]"<?php if ( !(int)get_site_option( 'show-loggedout-adminbar' ) ) : ?> checked="checked"<?php endif; ?> id="bp-admin-show-loggedout-adminbar-no" value="0" /> No</code>
bp-core-ajax.php
112: <code><?php echo bp_core_get_last_activity( get_usermeta( $user->user_id, 'last_activity' ), ('active %s ago') ) ?></code>
bp-core-avatars.php
130: <code>bp_core_ap_die( 'Your upload failed, please try again. Error was: ' . $uploadErrors[$_FILESfile?error?] );
133:<code>bp_core_ap_die( 'The file you uploaded is too big. Please upload a file under ' . size_format(CORE_MAX_FILE_SIZE) );</code>
136:<code>bp_core_ap_die( 'Please upload only JPG, GIF or PNG photos.' );</code>
140:<code>bp_core_ap_die( 'Upload Failed! Error was: ' . $wp_upload_error );</code>
154:<code>bp_core_ap_die( 'Security error.' );</code>
157:<code>bp_core_ap_die('Error when cropping, please go back and try again');</code>
160:<code>bp_core_ap_die('Error when saving avatars, please go back and try again.');</code>
283: value
445: value
bp-core-classes.php
67: <code>$this->last_active = bp_core_get_last_activity( get_usermeta( $this->id, 'last_activity' ), ('active %s ago') );</code>
bp-core-signup.php
244:<code><input id="submit" type="submit" name="submit" class="submit" value="<?php _e('Next »') ?>"/></code>
341:<code><h3><?php _e('Still waiting for your email?'); ?></h3></code>
343:<code><?php _e("If you haven't received your email yet, there are a number of things you can do:") ?></code>
bp-core-widgets.php
96: alt
bp-core-directory-members.php
105:<code>('active %s ago')</code>
152: value
171: <code>('active %s ago')</code>
bp-forums-bbpress-live.php
20:<code>'description' => ('Forum lists from your bbPress forums')</code>
193: value
221: <code>'description' => ('The latest topics from your bbPress forums')</code>
392: value
397: value
bp-friends-templatetags.php
272: alt
363, 376 and 413: un-escaped apostrophe in string
Bp-groups-admin.php
37: value
47: value
Bp-groups-ajax.php
176: <code><h5><?php bp_group_member_link() ?> (banned) <span class="small"> — <a href="<?php bp_group_member_unban_link() ?>" title="Kick and ban this member">Remove Ban</a> </h5></code>
180: <code><h5><?php bp_group_member_link() ?> <span class="small"> — <a href="<?php bp_group_member_ban_link() ?>" title="Kick and ban this member">Kick & Ban</a> | <a href="<?php bp_group_member_promote_link() ?>" title="Promote this member">Promote to Moderator</a></span></h5></code>
250: domain
260: <code><?php _e( sprintf( '%d member', $member_count ), 'buddypress' ) ?></code>
262: <code><?php _e( sprintf( '%d members', $member_count ), 'buddypress' ) ?></code>
Bp-groups-templatetags.php
494: alt
856, 857, 865, 874, 883: value
1092, 1130, 1132: alt
1217: domain
1227: <code><?php _e( sprintf( '%d member', $member_count ), 'buddypress' ) ?></code>
1229: <code><?php _e( sprintf( '%d member', $member_count ), 'buddypress' ) ?></code>
1240: apostrophe
1252: apostrophe
1258: alt
1265: apostrophes
Change History (6)
#2
@
16 years ago
member-themes/buddypress-member/404.php: all of it
image.php: all of it
member-themes/buddypress-member/blogs/create.php
8: <h2>Create a Blog</h2>
member-themes/buddypress-member/wire/post-form.php
20: value
Bp-groups-widgets.php
35: alt
Bp-groups-directory-groups.php
107: domain
160: value
180: domain
Bp-wire-ajax.php
10: alt
Bp-xprofile-classes.php
472: <code> $html .= '<a class="clear-value" style="text-decoration: none;" href="javascript:clear(\'field_' . $this->id . '\');"><img src="' . $bp->profile->image_base . '/cross.gif" alt="Clear" /> Clear</a>';</code>
638, 639, 640: value
Bp-xprofile-signup.php
60: value
Buddypress-theme/buddypress-home/archive.php
32:<code> <?php next_posts_link('« Previous Entries') ?></code>
33:<code> <?php previous_posts_link('Next Entries »') ?></code>
38: title
39: time
45:<code> <?php edit_post_link('Edit' ), , ' | '); ?> <?php comments_popup_link('No Comments »', '1 Comment »', '% Comments »'); ?></code>
52:<code> <?php next_posts_link('« Previous Entries') ?></code>
53:<code> <?php previous_posts_link('Next Entries »') ?></code>
Attachment.php
12: title
16:<code><?php the_content('<p class="serif">Read the rest of this entry »</p>'); ?></code>
18:<code><?php wp_link_pages(array('before' => '<p><strong>Pages:</strong> ', 'after' => '</p>', 'next_or_number' => 'number')); ?></code>
Comments.php
24:<code><h3 id="responses"><?php comments_number('No Responses', 'One Response', '% Responses' );?> to “<?php the_title(); ?>”</h3></code>
42:<code><p class="commentmetadata"><a href="#comment-<?php comment_ID() ?>" title=""><?php comment_date('F jS, Y') ?> <?php _e( 'at', 'buddypress' ) ?> <?php comment_time() ?></a> <?php edit_comment_link('Edit',' [ ',' ]'); ?></p></code>
81:<code><p>Logged in as <a href="<?php echo site_url(); ?>/wp-admin/profile.php"><?php echo $user_identity; ?></a>. <a href="<?php echo site_url(); ?>/wp-login.php?action=logout" title="Log out of this account"><?php _e( 'Logout', 'buddypress' ) ?> »</a></p></code>
86:<code><label for="author"><?php _e( 'Name', 'buddypress' ) ?> <?php if ($req) echo "(required)"; ?></label></p></code>
96:<code><!--<p><strong>XHTML:</strong> You can use these tags: <code><?php echo allowed_tags(); ?></code></p>--></code>
Comments-popup.php
45:<code><p><cite><?php comment_type('Comment', 'Trackback', 'Pingback'); ?> <?php _e( 'by', 'buddypress' ) ?> <?php comment_author_link() ?> — <?php comment_date() ?> @ <a href="#comment-<?php comment_ID() ?>"><?php comment_time() ?></a></cite></p></code>
60: title
87: value
Index.php
11: title
12: <code><p class="date"><?php the_time('F jS, Y') ?> <em>in <?php the_category(', ') ?> by <?php echo bp_core_get_userlink($post->post_author) ?></em></p></code>
15: <code><?php the_content('Read the rest of this entry »'); ?></code>
18: <code><p class="postmetadata"><span class="tags"><?php the_tags('Tags: ', ', ', '<br />'); ?></span> <span class="comments"><?php comments_popup_link('No Comments »', '1 Comment »', '% Comments »'); ?></span></p></code>
26: <code><div class="alignleft"><?php next_posts_link('« Older Entries') ?></div></code>
27: <code><div class="alignright"><?php previous_posts_link('Newer Entries »') ?></div></code>
Page.php
10:<code><?php the_content('<p class="serif">Read the rest of this page »</p>'); ?></code>
12: <code><?php wp_link_pages(array('before' => '<p><strong>Pages:</strong> ', 'after' => '</p>', 'next_or_number' => 'number')); ?></code>
18: <code><?php edit_post_link('Edit this entry.', '<p>', '</p>'); ?></code>
Search.php
13: <code><div class="alignleft"><?php next_posts_link('« Previous Entries') ?></div></code>
14: <code><div class="alignright"><?php previous_posts_link('Next Entries »') ?></div></code>
20: title
21: time
23:<code><p class="postmetadata"><?php _e( 'Posted in', 'buddypress' ) ?> <?php the_category(', ') ?> | <?php edit_post_link('Edit', , ' | '); ?> <?php comments_popup_link('No Comments »', '1 Comment »', '% Comments »'); ?></p></code>
29: <code><div class="alignleft"><?php next_posts_link('« Previous Entries') ?></div></code>
30: <code><div class="alignright"><?php previous_posts_link('Next Entries »') ?></div></code>
35: domain
Searchform.php
3: value
Single.php
16: title
19: <code><?php the_content('<p class="serif">Read the rest of this entry »</p>'); ?></code>
21: <code><?php wp_link_pages(array('before' => '<p><strong>Pages:</strong> ', 'after' => '</p>', 'next_or_number' => 'number')); ?></code>