Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

#4865 closed enhancement (fixed)

BP Theme Compat : Group Invites list display

Reported by: imath's profile imath Owned by: boonebgorges's profile boonebgorges
Milestone: 1.8 Priority: normal
Severity: minor Version: 1.7
Component: Groups Keywords: has-patch needs-testing
Cc:

Description

Hi,

In the group invites list, the left column is not floating left leaving a right blank space. The members are showing under the radio inputs (400px under). It becomes a bit tricky when viewing the group invites screen on a smartphone..

The image i add to this ticket will explain this better, i think.

I've played a bit with css to customize my theme, so i thought it might be interested to share it in the attached diff (tested in twentyeleven, twentytwelve and my theme ).

Attachments (5)

group-invite.png (203.5 KB) - added by imath 11 years ago.
Image to illustrate the ticker
4865.diff (1.4 KB) - added by imath 11 years ago.
group-invite-list-left-smartphone.png (55.2 KB) - added by imath 11 years ago.
List on the left for the smartphone
4865-2.diff (1.2 KB) - added by imath 11 years ago.
The new diff (invites list stays on left)
4865-3.diff (1.2 KB) - added by imath 11 years ago.

Download all attachments as: .zip

Change History (12)

@imath
11 years ago

Image to illustrate the ticker

@imath
11 years ago

#1 @r-a-y
11 years ago

imath: Just want to say that you're doing some awesome work testing bp-legacy and providing patches!

#2 @johnjamesjacoby
11 years ago

Better than what we have, but would like to keep the list on the left if possible. Willing to take another stab at it?

#3 @imath
11 years ago

r-a-y: Thanks a lot :)

jjj: I ran some other tests, and i think in this case the best is to move the remove action button under the rest of the user elements. Adding an image to illustrate and a new diff with the changes i made.

@imath
11 years ago

List on the left for the smartphone

@imath
11 years ago

The new diff (invites list stays on left)

#4 @imath
11 years ago

In France we often say "Jamais 2 sans 3" (Never 2 without 3). Adding a new diff so that the username takes the full width instead of 75% (for the smartphone device).

@imath
11 years ago

#5 @boonebgorges
11 years ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 1.7

#6 @DJPaul
11 years ago

  • Milestone changed from 1.7 to 1.8

#7 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7209:

Improve appearance of Send Invites screen in bp-legacy

This changeset ensures that the invited members list does not break underneath
the friends checkbox list.

Fixes #4865

Props imath

Note: See TracTickets for help on using tickets.