messge compose autocompletefb.js splitting user name wrongly

[mort3n]

In

/bp-messages/js/autocomplete/jquery.autocompletefb.js

the user should be removed by

removeUsername: function(o){
var newID = o.parentNode.id.split('-');
jQuery('#send-to-usernames').removeClass(newID[1]);

The id being split contains the string 'un-user_name'. The code works great when 'user_name' contains no '-'. However, with

user_name = 'john-doe'

the code tries to remove class

john

which fails.
Using a

-

seems to be valid in user names
​http://codex.wordpress.org/Function_Reference/sanitize_user

A fix is

removeUsername: function(o){
var newID = o.parentNode.id.substr(3);
jQuery('#send-to-usernames').removeClass(newID);

Another fix is

removeUsername: function(o){
var newID = o.parentNode.id.substr((o.parentNode.id.indexof('-'));
jQuery('#send-to-usernames').removeClass(newID);

[boonebgorges]

Good catch. Ideally I'd like to see us stop using jquery.autocompletefb.js and use something that comes with WP (or is at least not crummy); see #4580. However, this seems like a straightforward fix if we keep the fb version for a few more releases.

[boonebgorges]

In 6928:

Improve JS for removing items from message recipient autocomplete list

This changeset introduces a more reliable method for removing usernames from
the list of message recipients, which works properly with usernames that
contain hyphens.

Fixes #4779

Props mort3n