Opened 12 years ago
Closed 12 years ago
#4764 closed defect (bug) (fixed)
Troubles with bp_get_activity_secondary_avatar
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 1.7 | Priority: | normal |
| Severity: | normal | Version: | 1.7 |
| Component: | Activity | Keywords: | |
| Cc: | rachel@… |
Description
i don't know if it's linked to the fact that i'm testing 1.7 using bp theme compat, but it looks like there's a trouble with bp_get_activity_secondary_avatar.
1/ The link of the group secondary avatar is not set, as the function groups_get_group is waiting for args that are not set at line 1080 of bp-activity-template.php. As a result i have the the trouble illustrated in image group-link.png attached to this ticket
2/ In the case of a friend request, the secondary avatar breaks the html as it includes a link in a link : see image friend-link.png for an illustration.
I suggest the diff included, it seems it has resolved my troubles with my theme. But i haven't tested when using bp-default..
btw : i love this next version, great work !
(In [6759]) Correct link on secondary activity avatars. Fixes #4764, props imath