Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 6 years ago

#4742 closed enhancement (maybelater)

Widgets filters: make tab links work with no-js

Reported by: jidanni's profile jidanni Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Templates Keywords: dev-feedback, 2nd-opinion, trac-tidy-2018
Cc:

Description

On http://www.bdsm.com.tw/groups/spanking/
I don't get why all these links link to the same place:

href="http://www.bdsm.com.tw/wp/groups" id="newest-groups">最新</a> | <a
href="http://www.bdsm.com.tw/wp/groups" id="recently-active-groups" class="selected">活動</a> | <a
href="http://www.bdsm.com.tw/wp/groups" id="popular-groups" >熱門</a></div><ul
href="http://www.bdsm.com.tw/wp/members" id="newest-members" >最新</a> | <a
href="http://www.bdsm.com.tw/wp/members" id="recently-active-members" class="selected">活動</a> | <a
href="http://www.bdsm.com.tw/wp/members" id="popular-members" >熱門</a></div><ul

Change History (8)

#1 @jidanni
11 years ago

Oh, I see. It works differently in javascript browsers.

Well it just happens that I am using a text browser,
to try to make even a little sense out of this
Buddypress enhanced very complicated site. What a disaster.

#2 @DJPaul
11 years ago

  • Component changed from Core to Theme
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from links link to the same place to make group tab links work with no-JS
  • Type changed from defect (bug) to enhancement

#3 @jidanni
11 years ago

"NSFW"

#4 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates

#5 @slaFFik
7 years ago

  • Keywords dev-feedback 2nd-opinion added
  • Summary changed from make group tab links work with no-JS to Widgets filters: make tab links work with no-js

In my opinion those tabs are secondary filters, that are not at all critical for non-js browsing.

We can use hide-if-no-js class, that is used in wp-admin area, add styles for it (display:none) in our buddypress.css. But it will be global, so better naming is required, like bp-hide-if-no-js?

@hnla Could I please get a feedback from you about this? Is it possible/hard/worth doing for at least of our widgets?

#6 @hnla
7 years ago

@slaFFik Agreed these are non critical.

Problem might be viewed as these should have been written in a Progressive Enhancement manner with a eye on Graceful Degradation.

They technically should work with Ajax added/used to provide a better UX.

However to adding a class bp-hide-if-no-js I think that is a win win it could be useful to have as a general provision used as when needed, with the cost of implementing relatively cheap with no terrible overheads.

We would provide a ruleset similar to the way we do with screen reader ruleset, any element we would not want rendering if no JS has the class added then we add a line to our JS to remove this class where found.

The alternative view might be though that sites nowadays are pretty much unusable and broken if JS not running and thus pointless making provisions like this, but I think it's still a useful provision.

Lets add this (new ticket it).

#7 @DJPaul
6 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#8 @DJPaul
6 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.