Skip to:
Content

BuddyPress.org

Opened 7 years ago

Last modified 3 years ago

#4740 new enhancement

Activity comments missing from group feed

Reported by: jidanni Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version: 1.2
Component: Activity Keywords: needs-patch 2nd-opinion
Cc:

Description

http://www.bdsm.com.tw/groups/self-introduction/feed/ lacks
http://www.bdsm.com.tw/groups/self-introduction/ 's comments,
and there is no way to find a URL to where one can obtain comments.

With comments gone, sites appear very dead.

With instead "Jones joined the group" reminders there in RSS, the group looks like it is being spammed.

Be sure to provide RSS links with e.g. comments=yes&joined_group=no
so end users can taylor a feed.

No I don't know what version they are using.

Change History (6)

#1 @jidanni
7 years ago

"NSFW"

#2 @r-a-y
7 years ago

  • Component changed from Core to Activity
  • Summary changed from comments missing from feed! to Activity comments missing from group feed
  • Version set to 1.2

The main gist of the problem is activity comments are tied to the user and not the group, so adding activity comments into a group feed might be a little troublesome.

#3 @boonebgorges
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

#4 @slaFFik
3 years ago

  • Keywords 2nd-opinion added

I tend to agree with @jidanni, that we might need to display all activity of the group in its feed.
We can't easily get that info from activity table.

My thoughts:

1) Why do we store in secondary_item_id for replies the same ID as in item_id? IMO it would be logical to have there group_id instead.

2) We can use a recursion, when generating xml, to get all children (flat list by date, obviously) for each item that we put into feed.

#5 @slaFFik
3 years ago

  • Milestone changed from Future Release to 2.8

This ticket can't be closed until #7331 is not fixed.
Problem is in BP_Activity_Feed class using 'display_comments' => 'stream', which is broken.

For BuddyPress 2.8 I propose to just make stream work as expected, with no params for generating custom RSS feeds. Thus at least we will have all activity for groups feeds in an xml - and not just top level.

#6 @DJPaul
3 years ago

  • Milestone changed from 2.8 to Future Release
Note: See TracTickets for help on using tickets.