Skip to:
Content

#4737 closed defect (bug) (fixed)

Group Moderator Cannot Edit Base Group Details

Reported by: mercime Owned by:
Milestone: 1.7 Priority: normal
Severity: major Version: 1.6
Component: Groups Keywords: commit
Cc: mercijavier@…

Description

WP 3.5 and BP 1.6.2 and in
WP 3.6 alpha and BP 1.7 trunk

Group Moderator in group page clicks on Admin link and gets an error "You are not an admin of this group." Previously, Group Mod can change Group Name and Description. Just found out when I double-checked support forum post http://buddypress.org/support/topic/group-moderator-are-not-able-to-edit-delete-group/

  • I thought I saw something like this posted before in trac but cannot find it now.

Attachments (1)

4737-02.patch (1.5 KB) - added by mercime 15 months ago.
clean up

Download all attachments as: .zip

Change History (12)

comment:1 hnla16 months ago

If group mods could edit description or change group name or even, as the thread suggests, delete groups, what is the distinction between the two roles? Might as well not have mods simply call everyone admins! If the OP wants a member to have this capability why do they not simply make the user an 'admin'.

comment:2 mercime16 months ago

  • Cc mercijavier@… added

@hnla :-)

Group Moderator ability to at least change group details is in bp-groups-screens and bp-groups-template, didn't make that up :-S and same info added in Codex where you can see distinction between group mod and admin :-) http://codex.buddypress.org/user/setting-up-a-new-installation/group-settings-and-roles/

comment:3 hnla16 months ago

No was sure you didn't make it up :) but the thread and ticket made me wonder the point of a Mod capability & wasn't sure without looking quite what the distinction between group admins & mods actually was, but as a rule of thumb would find it odd if a heap of people a group admin had elevated to mods could then go and change group name and /or descriptions let alone delete an entire group.

comment:4 DJPaul16 months ago

  • Milestone changed from Awaiting Review to 1.6.3
  • Severity changed from normal to major

comment:5 mrjarbenne16 months ago

It may be too late for 2 cents worth, but I would tend to agree with @hnla . The Moderator of a group should be able to do just that: moderate content on the Activity stream, within group forums, and perhaps within other additional plugins (delete offensive member docs from bp-docs for example). Changing the name and description of a group should be an Administrative task. If moderators could do this before, then perhaps the fact that they can no longer do so should be considered a fix, and not a major issue at all.

comment:6 DJPaul15 months ago

  • Milestone changed from 1.6.3 to 1.7
  • Version set to 1.6

comment:7 Inkblots15 months ago

Just as I'd made clear with my case in the original Support forum concerning this ticket, I agree, along with hnla and mrjarbenne, that this, in fact, is not a problem at all, and that Group Moderators are fine just as they are concerning access rights and other such privileges. I vote to close/won't fix this one.

comment:8 mercime15 months ago

There should be a fix either way. If you want to remove that capability from the Group Mod, at the very least a fix should be made so that the "Admin" link won't show up in Group Mod's navigation, leading to error if the Admin link is clicked.

comment:9 djpaul15 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6758]) In Groups, don't show the "admin" nav item for group moderators. Fixes #4737, see r5462.

mercime15 months ago

clean up

comment:10 djpaul15 months ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

mercime's attached a patch for a few more places with the group admin/mod checks.

comment:11 djpaul15 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6777]) Update group admin logic to not allow moderators to save group settings via POST. Fixes #4737, props mercime

Note: See TracTickets for help on using tickets.