"join group" and similar buttons missing in listings for ajax browsing

[magnus78]

The "join group" button is missing in the groups listing when the content was fetched using ajax. This is because the ajax requests go through wp-admin/admin-ajax.php, and adding those buttons is protected by a is_admin() clause.

The same it true for other listings.

[magnus78]

proposed fix

[magnus78]

The patch just removes the

if ( !is_admin() )

[sbrajesh]

Instead removing if ( !is_admin() )
It will be a better approach to put the condition like this

if ( !is_admin()||(is_admin()&&defined('DOING_AJAX')) ) 

[magnus78]

proposed fix, v2

[magnus78]

That works too, dunno if it's worth the bother.

[boonebgorges]

We need the is_admin() check because of some load-order problem that otherwise occur in the dashboard.

[boonebgorges]

(In [6679]) Ensure that directory/header buttons are hooked when doing AJAX

Directory buttons (such as Join Group) were previously added only when
!is_admin(), to avoid fatal errors in the Dashboard when certain template
functions were undefined. This caused problems when the directory was refreshed
using AJAX, because is_admin() returns true when making calls to
admin-ajax.php. This changeset does an additional check to make sure that
the buttons are added correctly when DOING_AJAX, even if is_admin() returns
true.

Fixes #4736

Props magnus78, sbrajesh