Skip to:
Content

#4713 closed defect (bug) (fixed)

BP 1.6.2 breaks avatar uploads

Reported by: rossagrant Owned by:
Milestone: 1.6.3 Priority: normal
Severity: major Version: 1.6.1
Component: Core Keywords:
Cc:

Description

A very bizarre issue where uploading certain JPEGS, JPGS and PNGs causes BP to throw an error and the browser to spit out a broken link message.

the actual BP error is this:

Fatal error: Call to undefined function wp_get_image_editor() in /home/mytestsp/public_html/wp-content/plugins/buddypress/bp-core/bp-core-avatars.php on line 521

SOME images do still upload though, but i can't find a correlation through file size or anything. It's all very weird.

Confirmed in this forum topic here:

http://buddypress.org/support/topic/bizarre-avatar-issue-after-bp-1-6-2-update/#post-147077

Worked just fine in all previous versions of 1.6+ so something must have changed.

Change History (16)

comment:1 rossagrant16 months ago

I'm not sure if it's a dimension issue. If I create 190x190 square images of the original images that won't upload, then they upload just fine.

I'm pretty sure it's not a file size issue as some images that are smaller than images that can be uploaded will still fail.

comment:2 DJPaul16 months ago

1.6.2 requires WP 3.5.

comment:3 rossagrant16 months ago

Yep, WP 3.5 does redeem this issue.

I still see a slight issue that only the left half of the cropper actually appears now though.

After speaking to JJ, it appears that enqueueing 'jcrop' styling will fix it for now.

I take it everyone else sees this issue?

comment:4 DJPaul16 months ago

  • Milestone changed from Awaiting Review to 1.6.3

I haven't seen any forum reports about cropping after the upgrade to WP 3.5 + BP 1.6.2. We do need to update the minimum version in the readme, which we missed.

comment:5 djpaul16 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6681]) Update minimum required WordPress version in readme.txt to WP 3.5. Fixes #4713

comment:6 rossagrant16 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hey Paul! Just noticed you closed this ticket. Unfortunately the half cropper issue is still happening on a vanilla install of BP 1.6.2 and WP 3.5, plus another user reported same issue.

JJ says J Crop needs enqueuing http://buddypress.org/support/topic/only-right-half-of-avatar-cropper-showing-in-bp-1-6-2/

Happy New Year by the way!

comment:7 hnla16 months ago

:) how does editing a text file correct scripting errors Paul?

This is fixed by adding:

wp_enqueue_style( 'jcrop');

comment:8 djpaul15 months ago

(In [6707]) Prevent empty value warning during avatar cropping. See #4713

comment:9 djpaul15 months ago

(In [6708]) Prevent several empty value warnings during avatar cropping (branch). See #4713

comment:10 DJPaul15 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

I have just reviewed both branch and trunk against WordPress 3.5, and I found and fixed a few PHP notice warnings. In a clean environment, avatar cropping on BP-Default works fine for me on both versions of BuddyPress.

I am not saying there is a not problem, but I cannot recreate anything. As always, we need full instructions to recreate the problem, and in this case, I think it would be useful to know what other plugins and theme you are testing with in order to ascertain if there's a compatibility problem.

Happy to work through this with anyone on the forums, then we can open a new ticket if necessary :)

comment:11 follow-up: DJPaul15 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

After more testing by Boone, Ray, and myself, we found some things. Reopening.

comment:12 in reply to: ↑ 11 johnjamesjacoby15 months ago

Replying to DJPaul:

After more testing by Boone, Ray, and myself, we found some things. Reopening.

Ouch; no love. Should be easy to backport what's working in trunk.

comment:13 djpaul15 months ago

(In [6717]) Always enqueue jcrop when we're croppin' avatars. See #4713

comment:14 r-a-y15 months ago

I can confirm r6717 fixes the missing resize corners issue. Thanks for looking into this, Paul!

comment:15 hnla15 months ago

Just reversed my fix for this and manually applied patch to bp-core-cssjs.php /1.6.2/3.5 and can confirm fix looks good.

comment:16 DJPaul15 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.