Skip to:
Content

Opened 5 years ago

Closed 5 years ago

#4709 closed enhancement (fixed)

BP_Buttton block_self should apply to listings too

Reported by: magnus78 Owned by: boonebgorges
Milestone: 1.8 Priority: low
Severity: minor Version:
Component: Core Keywords: has-patch
Cc:

Description

The block_self param in BP_Button doesn't prevent buttons from appearing in listings. E.g. the Private Message button is shown for yourself in the members listing. It would seem natural for it to apply there too.

Attachments (2)

trac4709_bp_button_block_self.patch (645 bytes) - added by magnus78 5 years ago.
proposed fix
4709.patch (1.1 KB) - added by boonebgorges 5 years ago.

Download all attachments as: .zip

Change History (5)

@magnus78
5 years ago

proposed fix

#1 @johnjamesjacoby
5 years ago

  • Component changed from Core to Members
  • Keywords reporter-feedback added

Comparing the displayed user to the logged in user is the same as using bp_is_my_profile(). Unclear what exactly this fixes.

#2 @boonebgorges
5 years ago

  • Component changed from Members to Core
  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 1.8
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Type changed from defect (bug) to enhancement

I think magnus78 means something like 4709.patch, which I think is a good enhancement.

@boonebgorges
5 years ago

#3 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 6924:

In BP_Button, make 'block_self' work in member loops

block_self is designed to make buttons invisible when a user is looking at his
own page. This changeset makes it so that block_self also hides block_self
buttons during a bp_has_members() loop on the iteration where the current user
id is the currently iterated users.

Note that BP does not currently put any such buttons in the members directory.
This patch is for plugins/themes that add their own custom buttons.

Fixes #4709

Note: See TracTickets for help on using tickets.