Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#4669 closed defect (bug) (fixed)

'bp_head' hook does not exist for theme compat

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.7
Component: Templates Keywords: has-patch
Cc:

Description

bp-default has a hardcoded do_action( 'bp_head' ) in its header.php.

bp-legacy does not have such a hook. So any code hooked to 'bp_head' will not run when a theme other than bp-default is activated.

In r6529, I added the 'bp_head' hook to 'wp_head', but quickly reverted it due to backwards compatibility as explained in r6177.

In 01.patch, I've added the 'bp_head' hook to the BP_Theme_Compat class. This is so any classes that extend it like BP_Legacy and BP_TurtleShell can inherit it.

Attachments (1)

4669.01.patch (1.5 KB) - added by r-a-y 11 years ago.
Disregard this patch. BP_Theme_Compat class needs to be refactored entirely. New ticket will be created for this.

Download all attachments as: .zip

Change History (3)

@r-a-y
11 years ago

Disregard this patch. BP_Theme_Compat class needs to be refactored entirely. New ticket will be created for this.

#1 @johnjamesjacoby
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6605]) When in theme-compat, make sure 'bp_head' gets added to 'wp_head' action. Also introduce bp_head() function, and use in bp-default header.php. Fixes #4669.

#2 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.