Opened 12 years ago
Last modified 21 months ago
#4627 new defect (bug)
bp_core_fetch_avatar html pref checking should use !empty (again)
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Contributions | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | needs-unit-tests needs-patch |
Cc: | magnus.melin@… |
Description
Ok, so in #4215 the $html strict parameter checking was finally backed out since html='false' didn't work out in some existing theme code. (I just found out, trac doesn't send email to OP by default?)
I think we agreed it's still a good idea. I'd propose to do it, but just fix the 'false' case to by filter_var($html, FILTER_VALIDATE_BOOLEAN);
With this you can have html=false, html=0, html=no, html=true, html=1 etc.
Attachments (1)
Change History (7)
#2
@
12 years ago
- Keywords dev-feedback added
magnus78, if you go to Preferences (in the top-right of Trac), enter your email address and you'll receive updates of any changes on any changes that you created.
Boone, do we want to do this? I'm not familiar with this function, but http://www.php.net/manual/en/filter.filters.validate.php seems reasonable. Need unit tests?
#3
@
12 years ago
- Keywords needs-unit-tests added
- Milestone changed from Awaiting Review to Future Release
Need unit tests?
Yes. Let's punt until we have unit tests.
proposed fix