Skip to:
Content

BuddyPress.org

Opened 7 years ago

Last modified 4 years ago

#4627 new defect (bug)

bp_core_fetch_avatar html pref checking should use !empty (again)

Reported by: magnus78 Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version:
Component: Core Keywords: needs-unit-tests needs-patch
Cc: magnus.melin@…

Description

Ok, so in #4215 the $html strict parameter checking was finally backed out since html='false' didn't work out in some existing theme code. (I just found out, trac doesn't send email to OP by default?)

I think we agreed it's still a good idea. I'd propose to do it, but just fix the 'false' case to by filter_var($html, FILTER_VALIDATE_BOOLEAN);

With this you can have html=false, html=0, html=no, html=true, html=1 etc.

Attachments (1)

trac4215_avatar_html_pref_v2.patch (510 bytes) - added by magnus78 7 years ago.
proposed fix

Download all attachments as: .zip

Change History (7)

@magnus78
7 years ago

proposed fix

#1 @magnus78
7 years ago

  • Cc magnus.melin@… added

So this basically simulates !empty + the "false" case.

#2 @DJPaul
7 years ago

  • Keywords dev-feedback added

magnus78, if you go to Preferences (in the top-right of Trac), enter your email address and you'll receive updates of any changes on any changes that you created.

Boone, do we want to do this? I'm not familiar with this function, but http://www.php.net/manual/en/filter.filters.validate.php seems reasonable. Need unit tests?

#3 @boonebgorges
7 years ago

  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to Future Release

Need unit tests?

Yes. Let's punt until we have unit tests.

#4 @DJPaul
6 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Future Release to 1.8

We can do unit tests now!

#5 @boonebgorges
6 years ago

  • Milestone changed from 1.8 to Future Release

#6 @DJPaul
4 years ago

  • Keywords needs-patch added; has-patch removed
Note: See TracTickets for help on using tickets.