wp_create_thumbnail() deprecated as of WP 3.5 - avater uploads will fail currently

[hnla]

As of WP 3.5 wp_create_thumbnail() is deprecated:

Call to undefined function wp_create_thumbnail() in E:\www\vhost\wp-bleeding.dev\site\htdocs\wp-content\plugins\buddypress\bp-core\bp-core-avatars.php on line 521

/wp-admin/includes/deprecated.php : line 1013
@deprecated 3.5.0
@deprecated Use image_resize()

fixed if we set a mandatory third parameter for height:

$thumb = image_resize( $bp->avatar_admin->originalfile?, bp_core_avatar_original_max_width(), $requires_third_paramter_height );

[mercime]

related ​http://buddypress.trac.wordpress.org/ticket/4634

[DJPaul]

The error is thrown because wp_create_thumbnail() was in wp-admin/includes/image.php (which we've explicitly been including), but it's been moved to wp-admin/includes/deprecated.php.

I don't think this can be considered a regression in WP 3.5 as we've always explicitly included a file which is only used inside wp-admin by WP. We need to fix this in the 1.6 branch for a day zero release alongside WP 3.5, which gives us about a month to finish and test 1.6.2.

[djpaul]

(In [6562]) Fix avatar cropping for WordPress 3.5. Fixes #4608 for the 1.6 branch.

[djpaul]

(In [6564]) Fix avatar cropping for WordPress 3.5. Fixes #4608 for trunk.