filter select options out of sync with parent tab

[modemlooper]

As I'm working on menus I noticed that the filter select has the same options for whatever tab you are on in the attached image the select filter for favorites tab doesn't even work with any of those options. It just shows the same list regardless.

It has a filter for options other than acitivyt but you can not favorite these items. Maybe these options should be removed based on tab?

[DJPaul]

These are hardcoded in BP-Default/Legacy, so we'd have to rely on people updating themes for any fix. We don't track any relationship between filters and screens, i.e. bp_activity_set_action.

Perhaps the real bug is that the Filter dropdown doesn't work for the Favourites tab for activities in BP-Default. Can someone confirm behaviour on a 1.6 install?

[boonebgorges]

The filters don't work in 1.6.x either. Not a regression, so we'll handle it later.

[lakrisgubben]

Testing this on trunk and 2015 it works as it should I think. For example: If I favorite a "new group created" activity in the stream and then filter favorites on "new groups" it shows up there (same goes for new post etc).

On the mentions screen it seems a bit more strange to have these filter options though... One idea would be to change the context of bp_get_activity_show_filters() to 'mentions' when on the mentions screen as in attached patch. This would remove the default filter values while still letting plugins hook in and add new ones. Pros with this approach would be that we don't need to touch bp-legacy, the con is that the select box will still be visible but with only the 'everything' option available...