Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 5 years ago

Last modified 5 years ago

#4585 closed enhancement (wontfix)

Hardcoded width/height on avatar images cause problems with responsive image techniques

Reported by: djpaul's profile DJPaul Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

Hardcoded width/height on the avatar images cause problems with responsive image techniques. This was observed when testing the template packs on twentytwelve.

I'd like to just remove it. Possible backpat consequences with the page jumping around more as images are loading in, but I think it's worth the tradeoff.

Attachments (1)

4585.001.patch (2.4 KB) - added by DJPaul 10 years ago.

Download all attachments as: .zip

Change History (9)

@DJPaul
10 years ago

#1 @DJPaul
10 years ago

  • Milestone changed from 1.7 to Awaiting Review

#2 @johnjamesjacoby
10 years ago

If we can avoid the DOM dance, we should. Media queries to make them smaller where appropriate makes more sense here.

#3 @DJPaul
10 years ago

The reasoning is more to do with the images auto-shrinking to fit the size of the parent container, rather than jumping to specific sizes at certain breakpoints. However, that's an idea worth exploring. I'll ask karmatosed to comment as this ticket came from a discussion we had, and she knows more than I do about this area.

#4 @karmatosed
10 years ago

My only concern would be how older themes cope with this. If they don't have a width on image container then the image will load full size. Perhaps having some back up support with media queries could be good to step in if the theme doesn't. This would solve that.

My opinion though is that we should go for it as we're going to cause more issues holding onto fixed widths.

#5 @DJPaul
10 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 @DJPaul
6 years ago

  • Component changed from Appearance - Template Parts to Templates

#7 @DJPaul
5 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#8 @DJPaul
5 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.