Avoid "Notice: Undefined index" in bp_core_remove_nav_item

[wpdennis]

I added an action to "bp_setup_nav" to remove nav items like:

bp_core_remove_nav_item('blogs');
bp_core_remove_nav_item('forums');

This can result in "Notice: Undefined index" in line 389
​http://buddypress.trac.wordpress.org/browser/trunk/bp-core/bp-core-buddybar.php#L389.

Maybe we could avoid this in bp_core_remove_nav_item by adding:

if (!isset($bp->bp_nav[$parent_id]))
    return;

just before this if statement:

if ( $function = $bp->bp_nav[$parent_id]['screen_function'] ) {

[boonebgorges]

Great suggestion. We should actually return false (or maybe an error) so that plugin authors can get an appropriate response.

[wpdennis]

Replying to boonebgorges:

Great suggestion. We should actually return false (or maybe an error) so that plugin authors can get an appropriate response.

Thanks for your feedback.

Returning false would be even better than returning void. I would prefer false over an error, because it seems to be more consistent to me (bp_core_new_nav_item, bp_core_sort_nav_items & Co).

[jkudish]

return false if the parent item doesn't exist in bp_core_remove_nav_item() and adjust phpdoc for the function

[boonebgorges]

(In [6412]) Fixes PHP warning when attempting to remove nav item that doesn't exist

Fixes #4533

Props wpdennis, jkudish