bp_core_fetch_avatar hooking into get_avatar

[melindrea]

In its' core, get_avatar returns the gravatar with the classes avatar, avatar-$size and photo. Buddypress hooks in to the get_avatar filter (line 686, bp-core-avatars.php) to see if there is a locally uploaded avatar. The gravatar returned, whether local or not, has the classes avatar and user-$id-avatar.

I feel that it would be a good idea if the filter returned the same classes as the get_avatar, since it's very unexpected behaviour for them to not be there.

[DJPaul]

I can't see any reason not to do this?

[DJPaul]

Looking at these, we need to patch bp_core_fetch_avatar_filter(). We could use $width for the avatar-$size class, but $width is an optional parameter. If it's not set, what then? bp_core_avatar_full_width()? bp_core_avatar_thumb_width()?

Doesn't look to be too hard to patch if someone wants to go for it. The scope of the ticket is to add "avatar-$size" and "photo" to the avatars.

[jkudish]

bp_core_fetch_avatar(): adjust how the image width is set and how the html width attribute is created and add avatar-$width and photo classes to the html output by the function

[jkudish]

piggy back on top of the first patch and simplify a few things and make sure they are escaped too

[johnjamesjacoby]

(In [6601]) Clean up bp_core_fetch_avatar(). Props jkudish. Fixes #4503.