Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 5 years ago

#4473 closed enhancement (wontfix)

Don't deprecate bp_get_loggedin_user_nav()

Reported by: rogercoathup Owned by:
Milestone: Priority: low
Severity: minor Version: 1.6
Component: Core Keywords:
Cc:

Description

The comments for function bp_get_loggedin_user_nav() suggest it will be deprecated because it's not used by the core.

It's actually a useful function for 3rd party developers, allowing us to render a nav menu for the current user in locations other than the admin bar.

So, please don't deprecate.

Change History (4)

#1 follow-up: @boonebgorges
9 years ago

  • Keywords reporter-feedback added
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low

I'm not opposed to having a function that does what bp_get_loggedin_user_nav() and bp_get_displayed_user_nav() do, but it's not smart that they are separate from the main function for this purpose, bp_get_options_nav().

Can you describe how what you want to do cannot be done with bp_get_options_nav()? Maybe we can do some refactoring so that the up-for-deprecation functions are just wrappers for one centralized function.

#2 in reply to: ↑ 1 @rogercoathup
9 years ago

Replying to boonebgorges:

Can you describe how what you want to do cannot be done with bp_get_options_nav()? Maybe we can do some refactoring so that the up-for-deprecation functions are just wrappers for one centralized function.

My understanding is that they render different things (leastways according to their inline documentation):

bp_get_loggedin_user_nav() renders the top level navigation array

bp_get_options_nav() renders the sub level navigation for the current component.

So both are necessary.

#3 @DJPaul
8 years ago

I think the new in 1.7 function bp_nav_menu() sort-of resolves this ticket (or at least offers another option), so leaving open.

#4 @slaFFik
5 years ago

  • Keywords reporter-feedback removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

BP_Core_Nav is a successor, so closing this ticket.

Note: See TracTickets for help on using tickets.