Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4455 closed enhancement (fixed)

Switch to min.js convention

Reported by: nacin Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version:
Component: Component - Core Keywords:
Cc:

Description

Per #WP21633, core is likely to switch from .dev.js and .js, to .js and .min.js.

When this occurs, bumpbot will be updated to use the .min.js standard. So BuddyPress should probably follow suit.

Attachments (1)

4455.diff (14.9 KB) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 @DJPaul3 years ago

  • Milestone changed from Awaiting Review to 1.7

comment:2 @nacin3 years ago

Okay, this is ready for testing. First, a committer will need to run these commands:

svn mv bp-activity/admin/css/admin.css bp-activity/admin/css/admin.min.css; svn mv bp-activity/admin/css/admin.dev.css bp-activity/admin/css/admin.css; svn mv bp-core/admin/css/common.css bp-core/admin/css/common.min.css; svn mv bp-core/admin/css/common.dev.css bp-core/admin/css/common.css; svn mv bp-core/admin/css/wizard.css bp-core/admin/css/wizard.min.css; svn mv bp-core/admin/css/wizard.dev.css bp-core/admin/css/wizard.css; svn mv bp-core/css/admin-bar-rtl.css bp-core/css/admin-bar-rtl.min.css; svn mv bp-core/css/admin-bar-rtl.dev.css bp-core/css/admin-bar-rtl.css; svn mv bp-core/css/admin-bar.css bp-core/css/admin-bar.min.css; svn mv bp-core/css/admin-bar.dev.css bp-core/css/admin-bar.css; svn mv bp-core/css/buddybar-rtl.css bp-core/css/buddybar-rtl.min.css; svn mv bp-core/css/buddybar-rtl.dev.css bp-core/css/buddybar-rtl.css; svn mv bp-core/css/buddybar.css bp-core/css/buddybar.min.css; svn mv bp-core/css/buddybar.dev.css bp-core/css/buddybar.css; svn mv bp-messages/css/autocomplete/jquery.autocompletefb.css bp-messages/css/autocomplete/jquery.autocompletefb.min.css; svn mv bp-messages/css/autocomplete/jquery.autocompletefb.dev.css bp-messages/css/autocomplete/jquery.autocompletefb.css; svn mv bp-xprofile/admin/css/admin.css bp-xprofile/admin/css/admin.min.css; svn mv bp-xprofile/admin/css/admin.dev.css bp-xprofile/admin/css/admin.css; svn mv bp-activity/admin/js/admin.js bp-activity/admin/js/admin.min.js; svn mv bp-activity/admin/js/admin.dev.js bp-activity/admin/js/admin.js; svn mv bp-core/admin/js/wizard.js bp-core/admin/js/wizard.min.js; svn mv bp-core/admin/js/wizard.dev.js bp-core/admin/js/wizard.js; svn mv bp-core/js/widget-members.js bp-core/js/widget-members.min.js; svn mv bp-core/js/widget-members.dev.js bp-core/js/widget-members.js; svn mv bp-groups/js/widget-groups.js bp-groups/js/widget-groups.min.js; svn mv bp-groups/js/widget-groups.dev.js bp-groups/js/widget-groups.js; svn mv bp-messages/js/autocomplete/jquery.autocomplete.js bp-messages/js/autocomplete/jquery.autocomplete.min.js; svn mv bp-messages/js/autocomplete/jquery.autocomplete.dev.js bp-messages/js/autocomplete/jquery.autocomplete.js; svn mv bp-messages/js/autocomplete/jquery.autocompletefb.js bp-messages/js/autocomplete/jquery.autocompletefb.min.js; svn mv bp-messages/js/autocomplete/jquery.autocompletefb.dev.js bp-messages/js/autocomplete/jquery.autocompletefb.js; svn mv bp-messages/js/autocomplete/jquery.bgiframe.js bp-messages/js/autocomplete/jquery.bgiframe.min.js; svn mv bp-messages/js/autocomplete/jquery.bgiframe.dev.js bp-messages/js/autocomplete/jquery.bgiframe.js; svn mv bp-messages/js/autocomplete/jquery.dimensions.js bp-messages/js/autocomplete/jquery.dimensions.min.js; svn mv bp-messages/js/autocomplete/jquery.dimensions.dev.js bp-messages/js/autocomplete/jquery.dimensions.js; svn mv bp-xprofile/admin/js/admin.js bp-xprofile/admin/js/admin.min.js; svn mv bp-xprofile/admin/js/admin.dev.js bp-xprofile/admin/js/admin.js

Then, apply the attached patch.

@nacin3 years ago

comment:3 @johnjamesjacoby3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6264]) Switch to .min for compressed JS and CSS files.

  • This moves our "development" versions from .dev.js to .js (same for css).
  • The compressed version then moves from .js to .min.js (same for css).
  • By switching to the standard .min convention, it sets expectations for developers, and works nicely with existing tools such as ack.
  • Fixes #4455.
  • Props nacin.

comment:4 @johnjamesjacoby3 years ago

(In [6265]) Some deleted files were missed in r6264. See #4455.

Note: See TracTickets for help on using tickets.