Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 2 years ago

#4448 closed enhancement (maybelater)

"Friends > Pending" subnav page needed

Reported by: foxly Owned by: foxly
Milestone: Priority: normal
Severity: normal Version:
Component: Friends Keywords: trac-tidy-2018
Cc: karmatosed

Description

Latest versions of WP and BP.

If a user sends a friendship request to another user on a BP install running on the primary blog of a multisite WP install, the second user never receives that request.

To replicate:

1) Install the latest versions of WP and BP.
2) Upgrade the WP install to operate in multisite mode.
3) Create a test user and activate their account.
4) Set BP to the default theme.
5) Log in and log out on both the admin user and the test user. Clear browser caches.
6) Log in as the test user and send a friend request to the admin user. Clear browser cache.
7) Login as the admin user and view friend requests. The friend request from the test user will not appear in the list.

Can somebody else see if they can replicate this defect?

Attachments (5)

screen-cap.jpg (334.1 KB) - added by foxly 8 years ago.
database.jpg (185.7 KB) - added by foxly 8 years ago.
example-01.jpg (351.8 KB) - added by foxly 8 years ago.
example-02.jpg (338.7 KB) - added by foxly 8 years ago.
example-03.jpg (579.4 KB) - added by foxly 8 years ago.

Download all attachments as: .zip

Change History (15)

@foxly
8 years ago

@foxly
8 years ago

#1 @foxly
8 years ago

  • Severity changed from critical to normal

I have tested this on a production site and the defect doesn't happen, so this seems to be limited to my local install. Possibly caching related.

I'll investigate further and report back.

@foxly
8 years ago

@foxly
8 years ago

@foxly
8 years ago

#2 @foxly
8 years ago

  • Severity changed from normal to minor
  • Summary changed from Friendship Requests Broken on Multi Site in 1.6.1 to Confusing UI Behaviour in Friends Component

The UI in BP's friends component tripped me up earlier today because of a defect in our UI.

The root problem is the UI doesn't differentiate between the sender and the recipient of a friend request, and display that context in the UI.

Example:

Let's say "admin" sends a friend request to "test01", then both of them visit each other's profiles. Referring to "example-01.jpg" we can see its impossible to tell which user sent the other user the friend request.

Now let's say both users visit Members->Friends->Requests. Referring to "example-02.jpg" when "admin" views their requests list, there's no indication at all that they sent a friend request to "test01". When "test01" visits their requests list, they correctly see a friend request with the option to accept or reject the invitation.

Solution:

As demonstrated in "example-03.jpg", the UI should use unambiguous language on friendship action buttons when viewing user profiles. It should add should display pending friend requests on the initiating user's requests screen.

-F

#3 @DJPaul
8 years ago

  • Cc karmatosed added
  • Component changed from Friends to Theme
  • Milestone changed from Awaiting Review to 1.7
  • Type changed from defect (bug) to enhancement

Let's improve this screen in 1.7 with the theme compatibility work.

#4 @johnjamesjacoby
7 years ago

  • Milestone changed from 1.7 to 1.8

No patch; punting to 1.8.

#5 @boonebgorges
7 years ago

  • Milestone changed from 1.8 to Future Release

#6 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates

#7 @r-a-y
4 years ago

  • Component changed from Templates to Friends
  • Keywords good-first-bug added
  • Severity changed from minor to normal
  • Summary changed from Confusing UI Behaviour in Friends Component to "Friends > Pending" subnav page needed

The "Friends > Requests" tab is for people that have requested the logged-in user as a friend, so we shouldn't touch that.

I think what we need here is a new subnav item so a logged-in user can view the friendships that they have initiated, but are pending. We should call this new page, "Pending" or "Invitations". "Invitations" might be a better name, but might have some connotations with the Groups component (for better or worse).

Renaming ticket title to be more reflective.

#8 @DJPaul
4 years ago

  • Keywords good-first-bug removed

#9 @DJPaul
2 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#10 @DJPaul
2 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.