Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

#4446 closed enhancement (fixed)

Add some additional information to loader.php

Reported by: fanquake Owned by: fanquake
Milestone: 1.7 Priority: normal
Severity: minor Version: 1.6
Component: Core Keywords: has-patch dev-feedback
Cc: fanquake, jkudish

Description

Clean up the whitespace in loader.php and add the Revision date, Requires at least and License to the header.

Tested up to would also be another useful piece of information to add.

i.e Tested up to: WP 3.4.1, PHP 5.4.4, MYSQL 5.x.x

Attachments (2)

loader.php.patch (890 bytes) - added by fanquake 8 years ago.
4446.diff (1.0 KB) - added by jkudish 8 years ago.
add licence to loader header

Download all attachments as: .zip

Change History (9)

@fanquake
8 years ago

#1 @DJPaul
8 years ago

I don't have a problem with adding the License line in, but 'Requires at least' and 'Tested up to' are readme.txt headers.
I see no value in introducing a 'Revision Date' header, nor adding the PHP or MySQL versions to anywhere.

#2 @DJPaul
8 years ago

  • Keywords 2nd-opinion added

#3 @DJPaul
8 years ago

  • Keywords needs-patch added; has-patch 2nd-opinion removed
  • Milestone changed from Awaiting Review to 1.7

Let's put the license line into loader.php, and leave it as that.

@jkudish
8 years ago

add licence to loader header

#4 @jkudish
8 years ago

  • Cc jkudish added

#5 @jkudish
8 years ago

  • Keywords has-patch added; needs-patch removed

#6 @DJPaul
8 years ago

  • Keywords dev-feedback added

#7 @johnjamesjacoby
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6594]) Add license to bp-loader.php. Fixes #4446.

Note: See TracTickets for help on using tickets.