Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#4443 closed defect (bug) (fixed)

Remove EOF ?> per WordPress core standard

Reported by: djpaul's profile DJPaul Owned by: djpaul's profile DJPaul
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.0
Component: Core Keywords: has-patch commit
Cc:

Description

In WordPress 3.4, all of the end-of-file closing PHP tags were removed. BuddyPress should follow suit.

Ticket: http://core.trac.wordpress.org/ticket/12307 Revision: http://core.trac.wordpress.org/changeset/19712

Attachments (1)

4443.01.patch (60.8 KB) - added by r-a-y 12 years ago.

Download all attachments as: .zip

Change History (9)

@r-a-y
12 years ago

#1 @r-a-y
12 years ago

  • Keywords has-patch added

Attached patch is against r6299.

Please take a look before the patch gets stale!

#2 @DJPaul
12 years ago

  • Keywords commit added

Do we need a blank line at the bottom of each file? I'm looking at wpcore trunk, but it seems inconsistent; I'm not sure. We can always do a second commit if we need the blank lines.

#3 @r-a-y
12 years ago

Good question!

When I looked at [WP19712], the blank lines were omitted so I did the same in 01.patch.
In general, I like the extra line myself.

#4 @boonebgorges
12 years ago

Crud, it looks like it's gone stale already, for at least half a dozen files. r-a-y, this looks fine to me, will you just clean it up and commit it yourself? :)

#5 @r-a-y
12 years ago

The goal is to refresh this patch and commit it; I just want to try a smaller patch to commit first! :)

boonebgorges: I'm probably going to bug you later about SVN / Git / BuddyPress dev again before committing.

#6 @r-a-y
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6342]) EOF:

  • Fall in line with WordPress 3.4 coding practices by removing all EOF closing PHP tags.

#7 @johnjamesjacoby
9 years ago

  • Component changed from Component - Any/All to Tools - Code Improvement

#8 @DJPaul
8 years ago

  • Component changed from Tools - Code Improvement to Core
Note: See TracTickets for help on using tickets.