#4441 closed defect (bug) (fixed)
Duplicate Call to bp_get_user_meta_key in bp_settings_action_notifications
Reported by: | sbrajesh | Owned by: | |
---|---|---|---|
Milestone: | 1.6.2 | Priority: | normal |
Severity: | minor | Version: | 1.6 |
Component: | Toolbar & Notifications | Keywords: | has-patch |
Cc: | sbrajesh |
Description
Hi,
In bp_settings_action_notifications, we are calling bp_get_user_meta_key to generate the meta key and then update it using bp_update_user_meta which also calls bp_get_user_meta_key.
It amounts to double call on the meta key. When we filter on user meta key, the key saved to the table gets twice prefixed while the bp_get_user_meta used in various components notification settings, does not call the bp_get_user_meta_key twice(only called in bp_get_user_meta).
That causes incompatibility in the saved key and the retrieved key for the user notification settings.
Can we please fix it in the next update. It is causing issue with my Multi Network Plugin.
Please have a look at the patch attached.
Moving to 1.6.2 for review (may get bumped to 1.7).