Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 11 years ago

#4430 closed defect (bug) (fixed)

Use _x() for passing strings as function parameters

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.7 Priority: normal
Severity: minor Version:
Component: Core Keywords: needs-patch has-patch
Cc:

Description

When passing strings as function parameters, as is done with bp_core_get_last_activity() here http://buddypress.trac.wordpress.org/browser/branches/1.6/bp-members/bp-members-template.php#L634, it's not at all clear from context what the arguments like %s should be. Here we shoud use _x() instead of () to provide the necessary context.

Attachments (1)

4430.diff (731 bytes) - added by jkudish 12 years ago.
use _x() with a proper context when passing the string paramater to bp_core_get_last_activity()

Download all attachments as: .zip

Change History (3)

@jkudish
12 years ago

use _x() with a proper context when passing the string paramater to bp_core_get_last_activity()

#1 @DJPaul
12 years ago

  • Keywords has-patch added

#2 @johnjamesjacoby
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6615]) Use _x() to clarify string. Props jkudish. Fixes #4430.

Note: See TracTickets for help on using tickets.