Page <title> separator is hardcoded on BuddyPress pages

[schwarzaufweiss]

WP is using «-» as browser title separator, BP the pipe sign if your are e.g. on a group page. Why not also «-»?

[DJPaul]

Good spot. bp_modify_page_title() has hardcoded pipes, and we ​should use the $sep parameter. This looks to be an easy patch for someone.

[DJPaul]

Attached a patch. Could someone sanity check it please? Removed () because it doesn't seem to be appropriate; perhaps it was there to allow people to change the pipe character.

[boonebgorges]

I think that removing __() is fine as long as the replacement strings are the entire content of a between-the-pipes chunk. See #2595, #2555.

[DJPaul]

Still not sure how to proceed. Maybe use _x instead of , and explain what the replacement tokens mean (replacement tokens are the entire string).

[boonebgorges]

Use _x() for what? I think that the l18n for these strings happens somewhere further up the stream, at least in their standalone form. I think your patch is the way to go.

[DJPaul]

By default, the output might took like "Site Name | Component Name", but you can't choose to RTL it at the moment.

[boonebgorges]

Ah yes, RTL. _x() is probably the right thing to do, then.

[djpaul]

(In [6354]) Don't hardcode the separator token in the <title> block in BP-Default. Fixes #4419