Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#4419 closed enhancement (fixed)

Page <title> separator is hardcoded on BuddyPress pages

Reported by: schwarzaufweiss's profile schwarzaufweiss Owned by:
Milestone: 1.7 Priority: normal
Severity: minor Version: 1.6
Component: Core Keywords: has-patch 2nd-opinion
Cc:

Description

WP is using «-» as browser title separator, BP the pipe sign if your are e.g. on a group page. Why not also «-»?

Attachments (1)

4419.01.patch (918 bytes) - added by DJPaul 10 years ago.

Download all attachments as: .zip

Change History (9)

#1 @DJPaul
10 years ago

  • Component changed from Theme to Core
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 1.7
  • Severity changed from trivial to minor
  • Summary changed from Browser Title Separator to Page <title> separator is hardcoded on BuddyPress pages

Good spot. bp_modify_page_title() has hardcoded pipes, and we should use the $sep parameter. This looks to be an easy patch for someone.

@DJPaul
10 years ago

#2 @DJPaul
10 years ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed

Attached a patch. Could someone sanity check it please? Removed () because it doesn't seem to be appropriate; perhaps it was there to allow people to change the pipe character.

#3 @boonebgorges
10 years ago

I think that removing __() is fine as long as the replacement strings are the entire content of a between-the-pipes chunk. See #2595, #2555.

#4 @DJPaul
10 years ago

Still not sure how to proceed. Maybe use _x instead of , and explain what the replacement tokens mean (replacement tokens are the entire string).

#5 @boonebgorges
10 years ago

Use _x() for what? I think that the l18n for these strings happens somewhere further up the stream, at least in their standalone form. I think your patch is the way to go.

#6 @DJPaul
10 years ago

By default, the output might took like "Site Name | Component Name", but you can't choose to RTL it at the moment.

#7 @boonebgorges
10 years ago

Ah yes, RTL. _x() is probably the right thing to do, then.

#8 @djpaul
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6354]) Don't hardcode the separator token in the <title> block in BP-Default. Fixes #4419

Note: See TracTickets for help on using tickets.