Opened 13 years ago
Closed 13 years ago
#4419 closed enhancement (fixed)
Page <title> separator is hardcoded on BuddyPress pages
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 1.7 | Priority: | normal |
Severity: | minor | Version: | 1.6 |
Component: | Core | Keywords: | has-patch 2nd-opinion |
Cc: |
Description
WP is using «-» as browser title separator, BP the pipe sign if your are e.g. on a group page. Why not also «-»?
Attachments (1)
Change History (9)
#1
@
13 years ago
- Component changed from Theme to Core
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 1.7
- Severity changed from trivial to minor
- Summary changed from Browser Title Separator to Page <title> separator is hardcoded on BuddyPress pages
#2
@
13 years ago
- Keywords has-patch 2nd-opinion added; needs-patch removed
Attached a patch. Could someone sanity check it please? Removed () because it doesn't seem to be appropriate; perhaps it was there to allow people to change the pipe character.
#4
@
13 years ago
Still not sure how to proceed. Maybe use _x instead of , and explain what the replacement tokens mean (replacement tokens are the entire string).
#5
@
13 years ago
Use _x()
for what? I think that the l18n for these strings happens somewhere further up the stream, at least in their standalone form. I think your patch is the way to go.
Good spot. bp_modify_page_title() has hardcoded pipes, and we should use the $sep parameter. This looks to be an easy patch for someone.