Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #4415, comment 2


Ignore:
Timestamp:
08/08/2012 08:01:00 PM (12 years ago)
Author:
boonebgorges
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4415, comment 2

    initial v1  
    33The root cause is the same as for #4329; you can read my explanation there. Briefly, because our internal content is marked 404 by WP until bp_core_load_template(); the check in maybe_redirect_404() happens before that and thus catches the incorrect 404; and the redirect takes place.
    44
    5 The real fix (for 1.7) will have to involve fixing the 404 issue described in #4329. (IMO it is an enormous bug and I'm not sure how we've gotten this far without it causing huge problems :) ) In the interim, I suggest 4415.01.patch, which unhooks and rehooks maybe_redirect_404(), so that it runs after BP's template logic (instead of being in a race condition with it). We'll remove this hack fix in 1.7, when the proper fix comes. Read my inline documentation for a more complete description of the problem and the workaround.
     5The real fix (for 1.7) will have to involve fixing the 404 issue described in #4329. (IMO it is an enormous bug and I'm not sure how we've gotten this far without it causing huge problems :) ) In the interim, I suggest 4415.patch, which unhooks and rehooks maybe_redirect_404(), so that it runs after BP's template logic (instead of being in a race condition with it). We'll remove this hack fix in 1.7, when the proper fix comes. Read my inline documentation for a more complete description of the problem and the workaround.
    66
    7 215, could I ask you to verify that 4415.01.patch fixes your issue?
     7215, could I ask you to verify that 4415.patch fixes your issue?