Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 4 years ago

Last modified 4 years ago

#4395 closed defect (bug) (fixed)

Activity management Edit screen - default panel states broken in multisite

Reported by: DJPaul Owned by: boonebgorges
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Cc:

Description

On the activity management Edit screen in multisite, some of the panels (Link, Type, Author ID) are hidden on regular WordPress, but not on multisite. The problem is that the action "set-screen-option" is not being called by set_screen_options() in WordPress core ($_POSTwp_screen_options? is not set).

This seems to be a wpcore bug but needs further investigation and reporting to wptrac if appropriate.

Attachments (1)

4395.diff (1.0 KB) - added by lakrisgubben 4 years ago.

Download all attachments as: .zip

Change History (8)

#1 @tw2113
4 years ago

This feels like something that should be confirmed in the current versions of everything

#2 @lakrisgubben
4 years ago

  • Keywords has-patch added

The problem seemed to be just a misspell. The function bp_activity_admin_edit_hidden_metaboxes checks for $screen->id != toplevel_page_bp-activity_network instead of $screen->id != toplevel_page_bp-activity-network i.e. with an underscore instead of a dash. Attached patch fixes that (plus some minor WPCS in the above mentioned function) tested on WP4.7 and BP-trunk in both single-site and multisite and seems to solve the problem.

@lakrisgubben
4 years ago

#3 @DJPaul
4 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 2.8

woohoo!

#4 @tw2113
4 years ago

Good eye @lakrisgubben :)

#5 @boonebgorges
4 years ago

Whoa, good eye, @lakrisgubben.

I'm not sure why we hide these fields, but we should definitely be consistent.

#6 @boonebgorges
4 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 11355:

Ensure that hidden Activity metaboxes are hidden in Multisite.

Props lakrisgubben.
Fixes #4395.

#7 @johnjamesjacoby
4 years ago

Nice work @lakrisgubben!

Note: See TracTickets for help on using tickets.