Activity management Edit screen - default panel states broken in multisite

[DJPaul]

On the activity management Edit screen in multisite, some of the panels (Link, Type, Author ID) are hidden on regular WordPress, but not on multisite. The problem is that the action "set-screen-option" is not being called by set_screen_options() in WordPress core ($_POSTwp_screen_options is not set).

This seems to be a wpcore bug but needs further investigation and reporting to wptrac if appropriate.

[tw2113]

This feels like something that should be confirmed in the current versions of everything

[lakrisgubben]

The problem seemed to be just a misspell. The function bp_activity_admin_edit_hidden_metaboxes checks for $screen->id != toplevel_page_bp-activity_network instead of $screen->id != toplevel_page_bp-activity-network i.e. with an underscore instead of a dash. Attached patch fixes that (plus some minor WPCS in the above mentioned function) tested on WP4.7 and BP-trunk in both single-site and multisite and seems to solve the problem.

[DJPaul]

woohoo!

[tw2113]

Good eye @lakrisgubben :)

[boonebgorges]

Whoa, good eye, @lakrisgubben.

I'm not sure why we hide these fields, but we should definitely be consistent.

[boonebgorges]

In 11355:

Ensure that hidden Activity metaboxes are hidden in Multisite.

Props lakrisgubben.
Fixes #4395.

[johnjamesjacoby]

Nice work @lakrisgubben!