Private Groups request membership action is inconsistent for Admins

[rachelbaker]

When viewing a Group's page of which I am not a member, I can see the "Request Membership" button in the header but I don't have the Request Membership tab.
This is inconsistent with how the page is displayed for other users/roles that are not members of the group.

[rachelbaker]

BuddyPress Private Group View for Admin

[boonebgorges]

Yes, this is inconsistent.

The reason is that tabs on private groups are rendered differently for admins than for non-members (admins can see all tabs on all groups, regardless of group status). I don't believe this is a regression - it's been like this for a long time.

rachelbaker, do you have a suggestion for a better UI? Simply adding a Request Membership tab for admins?

[rachelbaker]

Replying to boonebgorges:

rachelbaker, do you have a suggestion for a better UI? Simply adding a Request Membership tab for admins?

I have been thinking about this for the past few days, and I can understand why the admin interface is different here. Originally, I was confused why I was missing the "Request Membership" tab while trying to troubleshoot an issue reported by a site's non-admin user (relating to ticket #4382).

I was thinking that the interface for the admins while having the additions, at the same time shouldn't have interface/interaction items removed. I didn't realize that this has been the case over previous releases.

[rachelbaker]

The proposed default theme/theme handling in 1.7 could be a place to fix this if there is anyone else that:
while logged in as admin -> viewing a group of which they are not a member -> didn't realize that they were not a member of the group.

Leaving open for a second opinion/feedback.

[dcavins]

This was addressed in r8159, v2.1