Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 8 years ago

#4309 closed defect (bug) (wontfix)

Deactivating BuddyPress while bp-default is active does not switch theme

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.5
Component: Core Keywords: needs-refresh
Cc:

Description

If you deactivate BuddyPress and bp-default is active, the theme will no longer exist and hence you will get a WSOD on the frontend until you manually switch the theme to something else.

Attached patch switches the theme to WP_DEFAULT_THEME when BP is deactivated. Patch is against 1.6-beta-1.

This behavior exists in 1.5 as well. Should there also be a patch for 1.5?

Attachments (1)

4309.01.patch (1.2 KB) - added by r-a-y 12 years ago.

Download all attachments as: .zip

Change History (6)

@r-a-y
12 years ago

#1 @DJPaul
12 years ago

We won't be putting anything else into 1.5 unless we have to (i.e. a critical regression or security issue reveals itself).

I'm not sure about this. It's always worked liked this, all the way back to 1.2. It's a bit specific to BP-Default. If a site had a theme which wasn't BP-Default (or its parent wasn't), it wouldn't catch those cases.

#2 @r-a-y
12 years ago

It's always worked liked this, all the way back to 1.2.

I didn't check 1.2 or lower, but you're right!

It's a bit specific to BP-Default. If a site had a theme which wasn't BP-Default (or its parent wasn't), it wouldn't catch those cases.

That's correct. It shouldn't need to deactivate any theme or child theme that isn't bp-default. Are you talking about themes that cloned bp-default instead?

Multisite installs that have bp-default activated on sub-blogs will need to be addressed as well, but I didn't go down that rabbit hole yet. Of course, when we deprecate bp-default, this issue will probably resolve itself.

#3 @DJPaul
12 years ago

  • Milestone changed from Awaiting Review to Future Release

#4 @DJPaul
11 years ago

  • Keywords needs-refresh added; has-patch removed

#5 @r-a-y
8 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Theme compatibility in BP 1.7 kind of renders this ticket moot.

Note: See TracTickets for help on using tickets.