Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 4 months ago

#4301 closed defect (bug) (fixed)

“Allow activity stream commenting on blog and forum posts” checkbox in the settings panel is backwards

Reported by: DJPaul Owned by:
Milestone: 1.6 Priority: normal
Severity: blocker Version: 1.6
Component: General - Administration Keywords: has-patch
Cc:

Description

From http://buddypress.org/2012/06/buddypress-1-6-beta-1/comment-page-1/#comment-10575

Got 1 bug to report in the new Beta. It seems that the “Allow activity stream commenting on blog and forum posts” checkbox in the settings panel is backwards. It allows commenting on blogposts when unchecked.

Confirmed on testbp.org with latest trunk.

Attachments (1)

4301.01.patch (4.6 KB) - added by boonebgorges 3 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 @DJPaul3 years ago

  • Severity changed from normal to blocker

comment:2 @DJPaul3 years ago

Please would the other options be checked, too, and confirm the defaults on a new install as well as a 1.5 upgrade.

comment:3 @boonebgorges3 years ago

Settings look good on a fresh install. About to test upgrades.

comment:4 @boonebgorges3 years ago

Settings look good on upgrades from 1.5.x.

comment:5 @boonebgorges3 years ago

  • Keywords has-patch added

Attaching a patch that fixes the original problem. Can I get someone else's eyes on it? I've stared at it for a while and need a sanity check.

@boonebgorges3 years ago

comment:6 @DJPaul3 years ago

Once this is in, we need to look at #3661

comment:7 @DJPaul3 years ago

In 1.5, bp-disable-blogforum-comment defaulted to a value of 0. It defaults to false in 1.6. Does the strict type check need changing?

comment:8 @boonebgorges3 years ago

It's being cast as bool before the strict type check, so it should be OK in theory. However, that strict check was a workaround for a different problem I was having, so I'll switch it back to using our API function.

comment:9 @boonebgorges3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6156]) Settings improvements

  • Corrects the logic of bp-disable-blogforum-comments, so that checking the 'Enable' setting actually enables rather than disables
  • Moves settings saving to its own function bp_core_admin_settings_save(), which can be run earlier in the load process and then redirect, ensuring that the correct settings are rendered in the first pageload after save

Fixes #4301

comment:10 @johnjamesjacoby4 months ago

  • Version changed from 1.6-beta to 1.6
Note: See TracTickets for help on using tickets.