“Allow activity stream commenting on blog and forum posts” checkbox in the settings panel is backwards

[DJPaul]

From http://buddypress.org/2012/06/buddypress-1-6-beta-1/comment-page-1/#comment-10575

Got 1 bug to report in the new Beta. It seems that the “Allow activity stream commenting on blog and forum posts” checkbox in the settings panel is backwards. It allows commenting on blogposts when unchecked.

Confirmed on testbp.org with latest trunk.

[DJPaul]

Please would the other options be checked, too, and confirm the defaults on a new install as well as a 1.5 upgrade.

[boonebgorges]

Settings look good on a fresh install. About to test upgrades.

[boonebgorges]

Settings look good on upgrades from 1.5.x.

[boonebgorges]

Attaching a patch that fixes the original problem. Can I get someone else's eyes on it? I've stared at it for a while and need a sanity check.

[DJPaul]

Once this is in, we need to look at #3661

[DJPaul]

In 1.5, bp-disable-blogforum-comment defaulted to a value of 0. It defaults to false in 1.6. Does the strict type check need changing?

[boonebgorges]

It's being cast as bool before the strict type check, so it should be OK in theory. However, that strict check was a workaround for a different problem I was having, so I'll switch it back to using our API function.

[boonebgorges]

(In [6156]) Settings improvements

• Corrects the logic of bp-disable-blogforum-comments, so that checking the 'Enable' setting actually enables rather than disables
• Moves settings saving to its own function bp_core_admin_settings_save(), which can be run earlier in the load process and then redirect, ensuring that the correct settings are rendered in the first pageload after save

Fixes #4301