Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#4297 closed enhancement (fixed)

Inconsistent quotes around latest update in member header

Reported by: modemlooper's profile modemlooper Owned by:
Milestone: 1.6 Priority: normal
Severity: trivial Version:
Component: Core Keywords:
Cc:

Description

When you post an update javascript switches out the latest update with quotes without page refresh. When you refresh page the quotes disappear. This is an inconsistent UX.

line 103 in global.js is the culprit: 

u = '"' + l + '" ';

I suggest no quotes. It makes it seems like somebody else's quote.

Change History (4)

#1 @DJPaul
12 years ago

This might be related to #4265

#2 @boonebgorges
12 years ago

  • Milestone changed from Awaiting Review to 1.6
  • Severity changed from normal to trivial

I think it's just inconsistent UX, as modemlooper suggests. The quotes were added when the middot was removed in r4809. I think the idea was to make it consistent with the way latest updates appear in the members directory (where they *do* have quotes).

I think it makes some sense to leave the quotes on the member directory, and to remove them altogether in the member header. This is essentially what modemlooper is suggesting.

#3 @boonebgorges
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6144]) Make the latest activity in member headers more consistent.

When updating the latest activity in a member header with JS, don't add
quotation marks, since there are no quotation marks output when the latest
update is loaded in the PHP template.

Fixes #4297

Props modemlooper

#4 @DJPaul
8 years ago

  • Component changed from General - UX/UI to Core
Note: See TracTickets for help on using tickets.