Straighten out group forum (bbPress 1.x) integration

[boonebgorges]

During the 1.6 dev cycle, some modifications were made to the admin to make way for the full transition to bbPress 2.x support. (See #3598.) Since the team has decided to release 1.6 without this feature, we need to do some cleanup to make sure that bbPress 1.x forums can still be installed and used inside of groups - basically, reverting to the "Group Forums/Sitewide Forums" setup from BP 1.5.x.

I've attached a patch that should make the necessary reversions. I've tested the following:

• Forum installation (MS and non-MS)
• Group creation with forums activated
• Posting/viewing group forums

All seems to be working, though it would be great to have it tested by a few others before committing.

This patch also fixes a strange bug that caused bb-config.php creation to fail when one of the WP salts contains the characters ?> next to each other.

[DJPaul]

4258.02.patch fixes a small issue where, when on the Forums admin page, the Settings >BuddyPress menu item wasn't bolded. Other than that, seemed ok.

[boonebgorges]

Thanks for having a look, DJPaul. I'm going to go ahead and commit this and mark the ticket fixed. If it turns out that we've missed something, let's either reopen or open a separate ticket.

[boonebgorges]

(In [6108]) Reinstates 1.5.x integration of bbPress 1.x forum installation and configuration

In anticipation for a full switchover to bbPress 2.x in BuddyPress 1.6, several
aspects of the forum configuration and setup process were modified. Since
the migration to bbPress 2.x is being put off to a later version of BuddyPress,
it's necessary to revert some of these changes back to their BP 1.5.x state.

This changeset also fixes a bug in the bb-config.php creation script, where
a salt containing the string '?>' could result in early termination of the
config file.

Fixes #4269