Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#4255 closed defect (bug) (fixed)

in bp_members_admin_bar_notifications_menu function the notification menu is not showing if WP3.4

Reported by: imath's profile imath Owned by:
Milestone: 1.5.6 Priority: highest
Severity: major Version: 1.5.5
Component: Core Keywords: has-patch
Cc:

Description

Hi,

if WordPress admin bar is set to default, then the notifications are not shown in WordPress admin bar. If the buddybar is set, no problem.

I've edited the function bp_members_admin_bar_notifications_menu located in file buddypress/bp-members/bp-members-adminbar.php at line 233 :

from this :

} elseif ( '3.3' == bp_get_major_wp_version() ) {

to this :

} elseif ( '3.3' <= bp_get_major_wp_version() ) {

it seems to resolve the trouble : now notifications are showing in WP3.4 if WP admin bar is set to default.

Attachments (1)

4255.patch​ (3.8 KB) - added by johnjamesjacoby 12 years ago.

Download all attachments as: .zip

Change History (3)

#1 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 1.5.6
  • Priority changed from normal to highest
  • Severity changed from normal to major

Confirmed. Haven't pushed 1.5.6 yet. Going to put it in now.

@johnjamesjacoby
12 years ago

#2 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6086]) WP Version Check:

  • Fixes missing notifications menu.
  • Fixes missing groups menu.
  • Correctly compares floats as numbers.
  • Fix non-yoda comparisons.
  • Fixes #4255 (1.5 branch)
Note: See TracTickets for help on using tickets.