Skip to:
Content

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#4253 closed enhancement (fixed)

Avatar cropper on touch devices

Reported by: modemlooper Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Component - Core Keywords:
Cc:

Description

iOS 6 includes uploads via mobile safari. BuddyPress images upload great but the cropper fails. I replaced jcrop and made it work. I checked to see what version WordPress was using and its an older version, however a patch was created to update jcrop in 3.4 http://core.trac.wordpress.org/ticket/20728

If its not included in 3.4 maybe the latst version of jcrop should be bundled with BP
http://deepliquid.com/content/Jcrop.html

Change History (7)

#1 @DJPaul
4 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release

I'd rather see if WP core will put this into a future 3.4.1 release. If it's not in WordPress by the time 1.7 rolls around, we can think about adding it into BuddyPrss. We have a couple of months before iOS 6.0 is due out.

#2 @modemlooper
4 years ago

I'll post on that jcrop ticket to let them know it's a needed update for BP avatars. I'd like to add avatar and image uploads to BP mobile

#3 @modemlooper
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

@nacin committed the patch to WP 3.5

#4 @boonebgorges
3 years ago

(In [6330]) Use correct argument swapping in BP_Activity_Activity::save() for item_id and secondary_item_id

Since BP 1.6, the item_id and secondary_item_id columns of the activity table
have been bigint rather than varchar. This changeset fixes the argument
swapping in BP_Activity_Activity::save() to use the appropriate %d rather than
%s, so that null values turn into zeroes. This helps to avoid errors on certain
strict MySQL setups.

Fixes #4253

#5 @boonebgorges
3 years ago

(In [6331]) Use correct argument swapping in BP_Activity_Activity::save() for item_id and secondary_item_id

Since BP 1.6, the item_id and secondary_item_id columns of the activity table
have been bigint rather than varchar. This changeset fixes the argument
swapping in BP_Activity_Activity::save() to use the appropriate %d rather than
%s, so that null values turn into zeroes. This helps to avoid errors on certain
strict MySQL setups.

Fixes #4253

#6 @boonebgorges
3 years ago

Referenced the wrong ticket number, oops.

#7 @johnjamesjacoby
3 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.