Opened 13 years ago
Closed 13 years ago
#4239 closed defect (bug) (fixed)
Fix filter parameters in groups_update_group_forum_post()
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 1.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Forums | Keywords: | has-patch |
Cc: |
Description
In the groups_update_group_forum_post()
function, the 'groups_activity_new_forum_post_action
' and 'groups_activity_new_forum_post_content
' filters were using the wrong parameters instead of those originally set in groups_new_group_forum_post()
.
The attached patch against r6059 makes sure these parameters are the same.
The patch also:
- Removes global $bp references for native BP functions in bp-group-forums.php
- Adds PHPDoc throughout bp-group-forums.php
Attachments (2)
Change History (9)
#2
@
13 years ago
Sad to say (because I would also like it to be "right") I agree with DJPaul here. We can't just change the filter parameters without breaking some stuff.
Happy to add more params at the end, though. And I like the rest of the patch :)
#3
@
13 years ago
- Keywords has-patch added; reporter-feedback removed
I can live with what DJPaul suggested :)
Repatched!
Thanks r-a-y.
While you're right about the filter change, it could cause backpat issues. I'd prefer we replace forum_post with topic (as forum_post isn't set), and if there is a good reason for further parameters, to just add those onto the end.