Fix filter parameters in groups_update_group_forum_post()

[r-a-y]

In the groups_update_group_forum_post() function, the 'groups_activity_new_forum_post_action' and 'groups_activity_new_forum_post_content' filters were using the wrong parameters instead of those originally set in groups_new_group_forum_post().

The attached patch against r6059 makes sure these parameters are the same.

The patch also:

• Removes global $bp references for native BP functions in bp-group-forums.php
• Adds PHPDoc throughout bp-group-forums.php

[DJPaul]

Thanks r-a-y.

While you're right about the filter change, it could cause backpat issues. I'd prefer we replace forum_post with topic (as forum_post isn't set), and if there is a good reason for further parameters, to just add those onto the end.

[boonebgorges]

Sad to say (because I would also like it to be "right") I agree with DJPaul here. We can't just change the filter parameters without breaking some stuff.

Happy to add more params at the end, though. And I like the rest of the patch :)

[r-a-y]

I can live with what DJPaul suggested :)

Repatched!

[DJPaul]

Looks good.

Whoever commits this: remove the duplicated "&$topic, &$topic"

[r-a-y]

The duplicated &$topic is needed because we decided that we didn't want to change any of the filter parameters except for replacing the unset $forum_post to &$topic.

The &$topic is the fourth parameter in the filters mentioned above. (Lines 113/114 and lines 274/275 of the patch.)

[djpaul]

(In [6064]) Removes global $bp references for native BP functions in bp-group-forums.php. Adds PHPDoc throughout bp-group-forums.php. Fixes #4239, props r-a-y