Skip to:

Opened 12 years ago

Closed 12 years ago

#4224 closed enhancement (fixed)

Basic Profile visibility - markup enhancements

Reported by: hnla's profile hnla Owned by:
Milestone: 1.6 Priority: normal
Severity: minor Version: 1.5.5
Component: Core Keywords: has-patch
Cc: hnla


A few adjustment to markup before 1.6 drops and can't easily change.

  • Remove orphaned 'label' element in parent .field-visibility-settings.
  • Add fieldset and legend to replace label for text 'who can see this field' in register.php | profile/edit.php
  • Change settings toggle to 'p' tag - text/pcdata not in non semantic agregator (div could be added back around 'p' tags but achieves little other than extra styling hook but bloats markup)
  • Adjust bp-xprofile-template 'bp_profile_get_visibility_radio_buttons()' to add labels & 'for' atts
  • Minor changes to global.js to hide radio buttons on load before running toggles and to contrast anchor toggles and radios with fadeOut & slideDown respectively to smooth out transitions (slightly less jerky)

Attachments (1)

profile-visibility-enhancements-4224-01.patch (5.6 KB) - added by hnla 12 years ago.

Download all attachments as: .zip

Change History (3)

#1 @boonebgorges
12 years ago

  • Milestone changed from Awaiting Review to 1.6

text/pcdata not in non semantic agregator

Meh. :)

Thanks for the patch, looks good.

#2 @boonebgorges
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6051]) Markup enhancements for profile visibility

  • Removes an orphaned 'label' element
  • Replaces some 'label' elements with 'fieldset' and 'legend' for greater accuracy
  • Changes some div elements into paragraphs, so that text does not appear outside the context of semantic elements
  • Modifications to the visibility options toggle JavaScript, for better differentiation and smoothness

Fixes #4224
Props hnla

Note: See TracTickets for help on using tickets.