Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4218 closed defect (bug) (fixed)

Disabling activation email with bp_core_signup_send_activation_key breaks the signup

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

See https://buddypress.trac.wordpress.org/browser/trunk/bp-members/bp-members-functions.php#L1098

If you filter 'bp_core_signup_send_validation_email' and return false, an activation key is never generated for the user in question. As a result, you end up with an unactivated user, but no key that you can feed to bp_core_activate_signup().

A quick is just to move the generation of the activation_key outside of the conditional. Then, at least, the filter will be doing what it claims to be doing: namely, to disable the activation *email* rather than the generation of a key. However, this may pose problems for backward compatibility. Thoughts?

See also #3443.

Change History (4)

#1 @DJPaul
12 years ago

At that point, user_status = 2 has already been set, and bp_core_signup_disable_inactive() will prevent such users to log in. As far as I see, those users *will* need a key to activate their account (I have no idea how they'd find out what their key is), so I think moving generation of the activation key outside of the conditional is safe.

This seems a bit of a weird filter, and we probably want to add true 'skip user account activation' in a future version.

#2 @boonebgorges
12 years ago

Thanks, DJPaul.

we probably want to add true 'skip user account activation' in a future version.

Yup. That's the subject of #3443.

#3 @boonebgorges
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6049]) On WP Single, always generate activation key

When 'bp_core_signup_send_activation_key' is filtered to false, an activation
key should still be generated, otherwise the newly created user will be unable
to activate her account. This changeset ensures that the activation key is
generated, even if a plugin is preventing the key from being sent via email.

Fixes #4218

#4 @DJPaul
12 years ago

  • Milestone changed from Awaiting Review to 1.6
Note: See TracTickets for help on using tickets.