bp_core_fetch_avatar html pref checking should use !empty

[magnus78]

When bp_core_fetch_avatar checks the html pref it checks it using true === $html. This makes it harder then necessary to override (e.g. passing $html=0 won't work). I propose to use !empty instead.

[magnus78]

proposed fix

[boonebgorges]

Agreed. This makes it unnecessarily hard to pass arguments in a URL style (...&html=1&...)

[boonebgorges]

(In [6046]) Eases up on type checks when passing an 'html' param to bp_core_fetch_avatar().

Fixes #4215. Props magnus78

[DJPaul]

This change in 1.6 has broken, amongst other things, the Salutation theme. Many forum posts:

http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/bp_core_fetch_avatar-issue-after-1-6-update/
http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/after-update-to-1-6-profilimagebug/
http://buddypress.org/community/groups/installing-buddypress/forum/topic/what-happened-to-our-avatars/
http://buddypress.org/community/groups/how-to-and-troubleshooting/forum/topic/weird-characters-showing-instead-of-avatar-picture-on-top-bar-after-installing-1-6-update/

[DJPaul]

Syntax that is being used seems to be: 'html' => 'false'

[boonebgorges]

Crud.

[boonebgorges]

(In [6246]) Do a strict type check for 'html' parameter in bp_core_fetch_avatar()

In r6046, the type check was loosened, to make it somewhat easier for themers
to pass a false value for 'html'. However, it was found after the 1.6 release
that this change broke backward compatibility with certain ways of calling
bp_core_fetch_avatar(). See #4215 for info on the original change.

Fixes #6046

Props rogercoathup

[boonebgorges]

(In [6247]) Do a strict type check for 'html' parameter in bp_core_fetch_avatar()

In r6046, the type check was loosened, to make it somewhat easier for themers
to pass a false value for 'html'. However, it was found after the 1.6 release
that this change broke backward compatibility with certain ways of calling
bp_core_fetch_avatar(). See #4215 for info on the original change.

Fixes #6046

Props rogercoathup

[boonebgorges]

Dang it, referenced the wrong ticket number. Fixed in previous two commits (1.6.x and trunk).