Problems with notices pagination not working

[chriskeeble]

With a large number of notices (in the test case concerned 54 notices) the pagination controls display correctly, but the full list of notices is returned on page 1, and clicking other page numbers returns an empty list (i.e. no pagination controls or notices, just the rest of the page).

Visible at [user profile] -> Messages -> Notices

(Logged in user must be a site admin to view this feature)

Tested in 2 themes including BP Default, and with all plugins disabled (except BuddyPress) results are the same.

[boonebgorges]

It looks to me that notice pagination has never worked - there's nothing in the code that even attempts to look at pagination variables. I've whipped up some very basic pagination, and disabled AJAX pagination for notices.

[boonebgorges]

(In [6044]) Fixes pagination for notices.

The Notices template has always show pagination markup, but the database
and template classes were never designed to handle pagination. This changeset
introduces the necessary logic in BP_Messages_Notice::get_notice() for
pagination to work.

Fixes #4204