Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#4193 closed defect (bug) (wontfix)

Main nav broken in RTL mode in IE7 on BP-Default

Reported by: djpaul's profile DJPaul Owned by:
Milestone: Priority: low
Severity: normal Version: 1.5
Component: I18N Keywords:
Cc:

Description

The main navigation menu is not displaying correctly in RTL mode in IE7 on BP-Default. This problem has existed since BP 1.5. LTR on IE7 works.

See #3595 for a lot of discussion and screenshots of the problem.

Attachments (2)

4193.01.patch (2.2 KB) - added by r-a-y 12 years ago.
4193.02.patch (2.2 KB) - added by r-a-y 12 years ago.

Download all attachments as: .zip

Change History (7)

@r-a-y
12 years ago

#1 @r-a-y
12 years ago

  • Component changed from Core to RTL
  • Keywords has-patch added; needs-patch removed
  • Version set to 1.5

Attached patch addresses various issues with the header in IE7.

The patch fixes:

  • Navigation hover menu so child list items properly show up underneath the main list item on hover.
  • h1 and search menu so it displays
  • Horizontal scrollbar so it doesn't show up - see line 351 of the patch. Opera users still see the horizontal scrollbar regardless though. For some alternative accessibility techniques, try the ones listed here - http://adaptivethemes.com/using-css-clip-as-an-accessible-method-of-hiding-content.

The patch does not fix:

  • the right offset of the page. (This bug has existed since BP 1.2.) The problem has something to do with the max-width and width declarations on the body element.
  • aligning the #nav to the left.

I've tested the patch on IE8, Firefox 12 and Chrome and it's non-destructive. As mentioned above, Opera users will still see the horizontal scrollbar with or without the patch.

With the patch applied, it will bring us pretty much on par with BP 1.2's RTL support.

Last edited 12 years ago by r-a-y (previous) (diff)

@r-a-y
12 years ago

#2 @r-a-y
12 years ago

02.patch fixes issues with the .accessibly-hidden class showing up when using LTR.

The left declaration is needed for all good browsers. text-indent is needed for IE7 when using RTL because of the horizontal scrollbar issue stated above.

The text-indent declaration could be moved to the default-rtl.css file instead.

#3 @DJPaul
11 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix as we shouldn't waste time on IE7 support nowadays, plus weary of breaking BP-Default and causing other issues at this point in its life.

#4 @DJPaul
11 years ago

  • Keywords has-patch removed

#5 @DJPaul
8 years ago

  • Component changed from Locale - RTL to I18N
Note: See TracTickets for help on using tickets.