Several problems with i18n and fixes

[slaFFik]

Hi,

1) bp_core_load_buddypress_textdomain() -> $mofile_local:
It has two slashes in the path. Reason: BP_PLUGIN_DIR is already trailingslahit'd and you are adding one more slash:

$mofile_local = BP_PLUGIN_DIR . '/bp-languages/' . $mofile;

mofile_local.patch fixes this.

2) On this url wp-admin/admin.php?page=bp-page-settings names of directories are not translatable. Currently didn't find how to fix.
The code is loading data from BP_Activity_Component::_construct() (for example) - where the description string is translatable, although not translated on front-end.

3) Settings -> BuddyPress -> Components:
This text:

All (10) | Active (10) | Inactive (0) | Must-Use (2)

is untranslatable. There is an error in using _n/_nx functions for displaying plurals there.

components_numbers.patch fixes this.

4) Settings -> BuddyPress -> Permalinks:
"View" and "New page" were untranslatable.

uni18n.patch fixes this.

[slaFFik]

Fixes on more place with untranslatable _n()

[slaFFik]

Fixing type in locale: buddpress->buddypress

[slaFFik]

Untranslatable word "Change" in buddypress/bp-themes/bp-default/members/single/profile/edit.php

[slaFFik]

About 2)
Perhaps code from bp-{$component_id}-loader.php is loaded before bp_init is initialized. Translation is loaded in such way:

add_action('bp_init', '{func_that_loads_translation}', 2);

I tried to change this - no success.

[djpaul]

(In [6015]) Correct several mistakes with i18n in strings. See #4190, props slaFFik

[DJPaul]

Thanks for the patches, slaFFik. Leaving ticket open for the directory name issue that you report.

[slaFFik]

Found how to easily fix it.

[slaFFik]

Fix issue 2) - translation was loaded not in the right time

[DJPaul]

I looked into this a bit more, and it seems the right solution. Thanks for the patch, slaFFik!

[djpaul]

(In [6028]) Load .mo files before init to fix strings being missed in components' loader classes. Fixes #4190, props slaFFik