Opened 13 years ago
Closed 13 years ago
#4182 closed defect (bug) (fixed)
Duplicate group invitations cannot be cleared
Reported by: | boonebgorges | Owned by: | |
---|---|---|---|
Milestone: | 1.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | |
Cc: |
Description
In the past (I think not anymore, but who knows?), BuddyPress was a little sloppy about cleaning up multiple group membership requests/invitations. So sometimes you would be invited to a group that you had previously requested membership in, and when membership was approved, the invitation was not also marked as accepted (or deleted). The result is that you have a group invitation that cannot be accepted, because the first thing BP does in groups_accept_invite()
is to check whether the user is already a member, and if so return false.
Better behavior would be: If the user is already a member of the group, then delete all outstanding requests/invitations, and return *true*, since the state of affairs being requested - to be a member of the group - actually obtains.
Note that this doesn't prevent the problem from happening in the first place, but (a) I think that the source of the problem has been solved elsewhere, and (b) it doesn't hurt to be redundant in this case.
(In [6013]) In groups_accept_invite(), if the user is already a group member, do some cleanup and return true. Prevents bugs related to duplicate uncleared membership requests/invitations. Fixes #4182