Favorite/Remove Favorite ajax does not report failure

[boonebgorges]

The AJAX handlers bp_dtheme_mark_activity_favorite() and bp_dtheme_unmark_activity_favorite() return the opposite text string, regardless of what bp_activity_add_user_favorite() or bp_activity_remove_user_favorite() return. As a result, if those functions return false, it'll look to the user like the action has been successful.

See ​https://github.com/karmatosed/Status/issues/70

[DJPaul]

What do you want it to do? Just return "Favourite" again if the favouring fails, etc ?

[boonebgorges]

I think that a real error message would be best, but I'll admit that I'm not quite sure how it would work. However, returning "Favorite" when favoriting fails, as you suggest, is certainly a more accurate way to respond than the current system.

[djpaul]

(In [6017]) Improve error messaging if AJAX activity favourite/unfavourite fails. See #4152

[DJPaul]

I've tweaked the message to return the same text again if the action fails; at least it is more accurate now. Putting ticket in future release milestone for further consideration or patches of how we should handle this better.

[slaFFik]

As the initial issue is fixed by Paul years ago, and there is no interest and new ideas about how to handle error reporting on failure (and in my opinion we should not display error in this case for end-user), I'm closing this ticket as actually fixed. IMO - this is not urgent and not important task.

In case you have ideas and/or passion to move it further and provide a feedback mechanism - feel free to reopen.