Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 7 years ago

#4152 closed defect (bug) (fixed)

Favorite/Remove Favorite ajax does not report failure

Reported by: boonebgorges's profile boonebgorges Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

The AJAX handlers bp_dtheme_mark_activity_favorite() and bp_dtheme_unmark_activity_favorite() return the opposite text string, regardless of what bp_activity_add_user_favorite() or bp_activity_remove_user_favorite() return. As a result, if those functions return false, it'll look to the user like the action has been successful.

See https://github.com/karmatosed/Status/issues/70

Change History (7)

#1 @DJPaul
12 years ago

  • Milestone changed from Awaiting Review to 1.6

#2 @DJPaul
12 years ago

What do you want it to do? Just return "Favourite" again if the favouring fails, etc ?

#3 @boonebgorges
12 years ago

I think that a real error message would be best, but I'll admit that I'm not quite sure how it would work. However, returning "Favorite" when favoriting fails, as you suggest, is certainly a more accurate way to respond than the current system.

#4 @djpaul
12 years ago

(In [6017]) Improve error messaging if AJAX activity favourite/unfavourite fails. See #4152

#5 @DJPaul
12 years ago

  • Milestone changed from 1.6 to Future Release

I've tweaked the message to return the same text again if the action fails; at least it is more accurate now. Putting ticket in future release milestone for further consideration or patches of how we should handle this better.

#6 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates

#7 @slaFFik
7 years ago

  • Milestone Future Release deleted
  • Resolution set to fixed
  • Status changed from new to closed

As the initial issue is fixed by Paul years ago, and there is no interest and new ideas about how to handle error reporting on failure (and in my opinion we should not display error in this case for end-user), I'm closing this ticket as actually fixed. IMO - this is not urgent and not important task.

In case you have ideas and/or passion to move it further and provide a feedback mechanism - feel free to reopen.

Note: See TracTickets for help on using tickets.