Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #4141, comment 3


Ignore:
Timestamp:
04/13/2012 12:36:39 PM (12 years ago)
Author:
chrisclayton
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4141, comment 3

    v1 v2  
    11Agreed. Knew there was a reason i wanted advice :) Don't think i was too confident in that patch.
    22
    3 Haven't tested it and i could be reading it wrong, but looking through the bp_rel_canonical function (thanks btw, somehow i missed that update) it already seems to detect every page possible so, wouldn't we just be repeating the same code in both? (or am i reading it wrong?)
     3Haven't tested it and i could be reading it wrong, but looking through the bp_rel_canonical function (thanks btw, somehow i missed that update) it already seems to detect every url possible so, wouldn't we just be repeating the same code in both? (or am i reading it wrong?)
    44
    55Wouldn't moving the url building stuff into bp_get_permalink() and returning the url_stack and then changing bp_rel_canonical() to simply just echo the bp_get_permalink()?