Skip to:
Content

Opened 6 years ago

Closed 5 years ago

Last modified 2 years ago

#4116 closed enhancement (fixed)

add rules for html5 input types to bp-default theme

Reported by: magnus78 Owned by: boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch 2nd-opinion
Cc: magnus.melin@…

Description

When creating a child theme of bp-default, one wants input fields to looks the same as the parent theme. But i still want to use input type="url" and other html5 goodies.

Would be nice if the default theme could include those rules by default. (And of course, there are at least a few places bp should use them as well.)

This is easily doable elsewhere, but i thought i'd submit it anyway.

Attachments (1)

trac4116_bp_theme_html5_inputs.patch (1.0 KB) - added by magnus78 6 years ago.
proposed fix

Download all attachments as: .zip

Change History (9)

#1 @DJPaul
6 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to Future Release

Do any other theme designers have any suggestion as to whether this could cause any unintended problems with the functionality of these new field types across browsers?

#2 @magnus78
6 years ago

  • Cc magnus.melin@… added

#3 @DJPaul
5 years ago

  • Milestone changed from Future Release to 1.8

#4 @boonebgorges
5 years ago

I'm going to put these in and see if it causes problems during the beta period.

#5 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7133:

Add form styling to HTML5 elements

This will allow HTML5 themes to inherit BP's form styles elegantly.

Fixes #4116

Props magnus78

#6 @hnla
5 years ago

Some thoughts:
@magnus78

bp-default, one wants input fields to looks the same as the parent theme. But i still want to use input type="url" and other html5 goodies.

Can understand that however BP-default was never built as a HTML5 running as it did/does with a trans xhtml dtd, thus building - as you state - a child theme and having to adjust that factor would tend to suggest - again as you end off with - that this is doable elsewhere and in fact is really part of the styling a true build theme or child theme should be dealing with.

As for the patch I would suggest it's not a great idea; firstly we are now adding a series of selectors into the mix that may or may not be used, they definitely won't be in BP-default themes (unless they've been modified at template level and not simply re-skinned) they also may not be used in the new 1.7 legacy files unless the theme in use has made this provision (yes most might have but...)

A group of selectors like this is unwieldy, and exist essentially to just counter the issue that might arise if one were - perhaps - more correctly styling on the main form controls input, textarea, select but then running attendant risk of adversely styling radio,checkbox.

In respect of bp-legacy - not originally a focus of this ticket - we have a slight clash with this ticket/patch and the UI-Refresh ticket where we are attempting to unravel the styling where possible from the stylesheet and are now here adding it in; however that ruleset does exist so not technically a set new styles, and sadly given that bp-legacy styles were released without modification and thus in the wild we are between a rock hard place in terms of what can actually be stripped out from it.

As for a 2nd-opinion this addition is unlikely to cause issues, but my preference given the above would be to not add anything now given we progress into a slightly different arena with template packs as a means forward in providing visually styled BP themes.

Last edited 5 years ago by hnla (previous) (diff)

#7 @karmatosed
5 years ago

There was no intentional clash and it has no impact on my styling. Just put a patch up with them kept in so no issue at all with the refresh ticket and this.

Personally, I think it hurts nobody having them in and is a great addition.

Last edited 5 years ago by karmatosed (previous) (diff)

#8 @DJPaul
2 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.