Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#4113 closed defect (bug) (fixed)

Users can be added to groups twice

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version: 1.5.4
Component: Groups Keywords:
Cc:

Description

Experienced a strange race condition where the same user was in the same group twice. Haven't done any investigating yet, but seems likely we need to check in BP_Groups_Member::save() for the user already being in the group before we insert them.

Change History (4)

#1 @boonebgorges
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5974]) Check to see whether a user is already a member of a group before creating a new membership in BP_Groups_Member::save(). Fixes #4113

#2 @boonebgorges
12 years ago

(In [6276]) Ensure that already-invited members can also request membership to private groups

This fixes a regression from r5974, in which an overly greedy check was put in
place to avoid duplicate group memberships. The pre-save check now only bails
when a confirmed membership is found.

Fixes #4113

#3 @boonebgorges
12 years ago

(In [6277]) Ensure that already-invited members can also request membership to private groups

This fixes a regression from r5974, in which an overly greedy check was put in
place to avoid duplicate group memberships. The pre-save check now only bails
when a confirmed membership is found.

Fixes #4113

#4 @boonebgorges
12 years ago

Ignore those commit messages. They were supposed to point to the related ticket #4495

Note: See TracTickets for help on using tickets.